Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prebid Core: Refine coordination of PBS+PBJS Floors #8865

Merged
merged 25 commits into from
Oct 6, 2022
Merged

Prebid Core: Refine coordination of PBS+PBJS Floors #8865

merged 25 commits into from
Oct 6, 2022

Commits on Sep 29, 2022

  1. stronger coordination between pbs and pbjs floors

    Jason Quaccia authored and Jason Quaccia committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    f64f05a View commit details
    Browse the repository at this point in the history

  2. reverted changes for test page

    Jason Quaccia authored and Jason Quaccia committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    d7707d7 View commit details
    Browse the repository at this point in the history

  3. spacing change

    Jason Quaccia authored and Jason Quaccia committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    5c30beb View commit details
    Browse the repository at this point in the history

  4. refactored code

    Jason Quaccia authored and Jason Quaccia committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    3c52473 View commit details
    Browse the repository at this point in the history

  5. reverted change to adunits html

    Jason Quaccia authored and Jason Quaccia committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    cf7b992 View commit details
    Browse the repository at this point in the history

  6. refactored pbjs to pbs floormin logic

    Jason Quaccia authored and Jason Quaccia committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    2aab46a View commit details
    Browse the repository at this point in the history

  7. refactored pbjs to pbs floormin logic

    Jason Quaccia authored and Jason Quaccia committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    cd53582 View commit details
    Browse the repository at this point in the history

  8. removed comment

    Jason Quaccia authored and Jason Quaccia committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    42993af View commit details
    Browse the repository at this point in the history

  9. refactored code

    Jason Quaccia authored and Jason Quaccia committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    0c18833 View commit details
    Browse the repository at this point in the history

  10. updated logic

    Jason Quaccia authored and Jason Quaccia committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    21dd216 View commit details
    Browse the repository at this point in the history

  11. no longer ignoring currencies

    Jason Quaccia authored and Jason Quaccia committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    24583e0 View commit details
    Browse the repository at this point in the history

  12. added fallback to deprecating prebid.floorMin and repositioned where … 

    …floorMinCur is set
    Jason Quaccia authored and Jason Quaccia committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    6bcb87f View commit details
    Browse the repository at this point in the history

  13. progress

    Jason Quaccia authored and Jason Quaccia committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    76d2924 View commit details
    Browse the repository at this point in the history

  14. updated floorMinCur logic

    Jason Quaccia authored and Jason Quaccia committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    fc9c3fe View commit details
    Browse the repository at this point in the history

  15. reverted code on example pages

    Jason Quaccia authored and Jason Quaccia committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    54b55e7 View commit details
    Browse the repository at this point in the history

  16. format adjustmnet

    Jason Quaccia authored and Jason Quaccia committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    df29ca7 View commit details
    Browse the repository at this point in the history

  17. format adjustment

    Jason Quaccia authored and Jason Quaccia committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    b4b4712 View commit details
    Browse the repository at this point in the history

  18. format adjustment

    Jason Quaccia authored and Jason Quaccia committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    e89357f View commit details
    Browse the repository at this point in the history

  19. updated currency conversion logic

    Jason Quaccia authored and Jason Quaccia committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    bd4f224 View commit details
    Browse the repository at this point in the history

  20. updated currency conversion logic

    Jason Quaccia authored and Jason Quaccia committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    e677d74 View commit details
    Browse the repository at this point in the history

  21. updated floorMinCur default for ortb2

    Jason Quaccia authored and Jason Quaccia committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    7bbc251 View commit details
    Browse the repository at this point in the history

  22. resolved conflicts

    Jason Quaccia authored and Jason Quaccia committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    de6864b View commit details
    Browse the repository at this point in the history

  23. formatting

    Jason Quaccia authored and Jason Quaccia committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    e33a67d View commit details
    Browse the repository at this point in the history

  24. formatting

    Jason Quaccia authored and Jason Quaccia committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    2a23818 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2022

  1. added few comments explaining the logic for this change

    Jason Quaccia authored and Jason Quaccia committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    c31c216 View commit details
    Browse the repository at this point in the history