LiveIntent Analytics Adapter: initial release #8960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* start work * send analytics event * Add first test and get winning bids from auctionManager * Add event test data and fix bugs * Remove duplicate userIds * add bidWonTimeout in configOptions * add sampling and adjust test * Add server test * Compare expected request body in the test * refactoring * update description * remove comment * comments * make sure we map defined data * refactoring * some refactoring * comments Co-authored-by: wiem <welabidine@liveintent.com>
7 tasks
wi101
commented
Sep 7, 2022
patmmccann
changed the title
leonelcuevas
reviewed
Sep 9, 2022
package.json
Outdated
| @@ -67,7 +67,7 @@ | |||
| "gulp-clean": "^0.3.2", | |||
| "gulp-concat": "^2.6.0", | |||
| "gulp-connect": "^5.7.0", | |||
| "gulp-eslint": "^4.0.0", | |||
| "gulp-eslint": "^6.0.0", | |||
There was a problem hiding this comment.
@musikele we were seeing an error during the linting step when we used the ?? operator.
After upgrading gulp-eslint the error is gone. Is it ok to upgrade?
There was a problem hiding this comment.
I am asking around. Will respond ASAP
There was a problem hiding this comment.
Hi @leonelcuevas , We have committed the gulp-eslint version change separately, can you rebase your PR ? then we can accept it
8 tasks
JacobKlein26
pushed a commit
to nextmillenniummedia/Prebid.js
that referenced
this pull request
Feb 9, 2023
* CM-552 Liveintent Analytics Adapter (#4) * start work * send analytics event * Add first test and get winning bids from auctionManager * Add event test data and fix bugs * Remove duplicate userIds * add bidWonTimeout in configOptions * add sampling and adjust test * Add server test * Compare expected request body in the test * refactoring * update description * remove comment * comments * make sure we map defined data * refactoring * some refactoring * comments Co-authored-by: wiem <welabidine@liveintent.com> * fix typo * Use getRefererInfo to get url and ?? operator for default values Co-authored-by: Leonel Cuevas Valeriano <leonel.cvs@gmail.com> Co-authored-by: leonelcuevas <lcuevas@liveintent.com>
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this pull request
May 23, 2023
* CM-552 Liveintent Analytics Adapter (#4) * start work * send analytics event * Add first test and get winning bids from auctionManager * Add event test data and fix bugs * Remove duplicate userIds * add bidWonTimeout in configOptions * add sampling and adjust test * Add server test * Compare expected request body in the test * refactoring * update description * remove comment * comments * make sure we map defined data * refactoring * some refactoring * comments Co-authored-by: wiem <welabidine@liveintent.com> * fix typo * Use getRefererInfo to get url and ?? operator for default values Co-authored-by: Leonel Cuevas Valeriano <leonel.cvs@gmail.com> Co-authored-by: leonelcuevas <lcuevas@liveintent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Add
liveIntentAnalyticsAdapter