Rubicon Bid Adapter: Choose video when banner mediaType is not present #8997
Conversation
| @@ -1990,6 +1990,19 @@ describe('the rubicon adapter', function () { | |||
| expect(spec.isBidRequestValid(bidderRequest.bids[0])).to.equal(false); | |||
| }); | |||
|
|
|||
| it('should be invalid if bidRequest.mediaTypes.video.context is instream but size_id is not defined', function () { | |||
There was a problem hiding this comment.
where is the check for this exactly? I do not see size_id being checked if instream anywhere.
There was a problem hiding this comment.
This test used to be under the hasVideoType tests, but it doesn't actually have anything to do with that function. I just moved it to where a bunch of other spec.isBidRequestValid situations were being tested. No idea if it tests what it is supposed to.
There was a problem hiding this comment.
yeah seems like a legacy test that does not do what is intended!
It is failing because we require
mediaTypes.video object to have a couple things.
Which is covered in should enforce the new required mediaTypes.video params
Can you just delete this test please!
There was a problem hiding this comment.
LGTM! @ChrisHuie Will you do a non Magnite review on this please?!
prebid#8997) * Choose video when banner mediaType is not present * Define video.params as needed * Refactor unit tests for classifiedAsVideo * Unit test fixes * Add video+banner+params.video test * Remove obsolete test
prebid#8997) * Choose video when banner mediaType is not present * Define video.params as needed * Refactor unit tests for classifiedAsVideo * Unit test fixes * Add video+banner+params.video test * Remove obsolete test
Type of change
Description of change
Rubicon's Adapter only classifies a bid as video when mediaTypes.video and params.video are both defined. This change causes the adapter to only check against params.video when mediaTypes.banner is also present, otherwise mediaTypes.video is enough to classify as video
Other information
@robertrmartinez