Reset hb_* keys only for registered adunits #902
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewlane
requested changes
Jan 5, 2017
| slot.setTargeting(key,null); | ||
| // Reset Only Registerd dfp-adunits | ||
| $$PREBID_GLOBAL$$.adUnits.find(function (unit) { | ||
| if(unit.code === slot.getSlotElementId()){ |
There was a problem hiding this comment.
unit.code should also check against slot.getAdUnitPath(). See https://github.com/prebid/Prebid.js/blob/master/src/prebid.js#L124 for a similar example
| @@ -113,7 +113,12 @@ function resetPresetTargeting() { | |||
| if (isGptPubadsDefined()) { | |||
| window.googletag.pubads().getSlots().forEach(slot => { | |||
| pbTargetingKeys.forEach(function(key){ | |||
| slot.setTargeting(key,null); | |||
| // Reset Only Registerd dfp-adunits | |||
There was a problem hiding this comment.
Please use spaces rather than tabs in this section to match the rest of the file
|
@darbh Any updates available? I'd like to get this into the next release |
1 task
|
This has been updated and rebased in #934 |
|
@matt Sorry, i am on vacation, just checked your mail. Thank you for
merging changes.
…On Friday, January 13, 2017, Matt Lane ***@***.***> wrote:
@darbh <https://github.com/darbh> Any updates available? I'd like to get
this into the next release
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#902 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ARNuMgoxJXaYNdv0FhxPy6eFxpdLGiROks5rRxzvgaJpZM4LZX2p>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Other information