Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vuukle Bid Adapter: support gdpr/usp/coppa/schain/gvlid #9023

Merged
merged 3 commits into from
Oct 6, 2022

Conversation

ChrisHuie
Copy link
Collaborator

Resubmit of pr #8957

Docs update -> prebid/prebid.github.io#4003

@Hamper
Copy link
Contributor

Hamper commented Sep 23, 2022

Do we need to fix something or CircleCI error unrelated to our changes?

@Rothalack
Copy link
Collaborator

Hey @Hamper I don't see a reason why your code is causing the circleci errors. If you try another arbitrary commit it should trigger another build and we can see if the errors are consistent or go away.

@ChrisHuie
Copy link
Collaborator Author

Let me double check this pr today. Might be my fault it isn't passing tests.

@Hamper
Copy link
Contributor

Hamper commented Oct 3, 2022

Tests fixed in original PR #8957

Copy link
Collaborator

@Rothalack Rothalack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, working in testing for me as well.

@Rothalack Rothalack merged commit 5c21bdc into master Oct 6, 2022
@Rothalack Rothalack deleted the vuukleAdapterUpdate branch October 6, 2022 13:49
JacobKlein26 pushed a commit to nextmillenniummedia/Prebid.js that referenced this pull request Feb 9, 2023
* add gdpr/usp/coppa/schain/gvlid

* restore getConfig

* fix linting
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this pull request May 23, 2023
* add gdpr/usp/coppa/schain/gvlid

* restore getConfig

* fix linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants