Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PubWise Bid Adapter: clean up and updates to adUnit parsing #9066

Merged
merged 4 commits into from
Oct 18, 2022
Merged

PubWise Bid Adapter: clean up and updates to adUnit parsing #9066

merged 4 commits into from
Oct 18, 2022

Conversation

GLStephen
Copy link
Collaborator

Update for PubWise Bid Adapter.

patmmccann
patmmccann reviewed Oct 3, 2022
View reviewed changes
modules/pubwiseBidAdapter.js Outdated
pageURL: refererInfo?.page || window.location.href,
refURL: refererInfo?.ref || window.document.referrer
pageURL: (refererInfo && refererInfo.referer) ? refererInfo.referer : window.location.href,
refURL: window.document.referrer
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why aren't you using refererInfo. Ref here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patmmccann not sure, I'll check, but looks like we should be

Copy link
Collaborator

@patmmccann patmmccann Oct 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refererInfo.ref and refererInfo.page have a bunch of logic attempting to determine them as of Prebid 7 merge. The todo was suggesting the right side of the || are unnecessary

Copy link
Collaborator Author

@GLStephen GLStephen Oct 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been adjusted in the next update. It was driven by a misunderstanding of the test environment where those values are less predictable.

@ChrisHuie ChrisHuie changed the title PubWise Bid Adapter Update PubWise Bid Adapter: clean up and updates to adUnit parsing Oct 3, 2022
@patmmccann
Copy link
Collaborator

one more question, could you solve for #8573 here? We're attempting to enforce all bidders pass:

auctionId as source.tid
bidderRequest[i].transationId as imp[i].ext.tid

@GLStephen
Copy link
Collaborator Author

one more question, could you solve for #8573 here? We're attempting to enforce all bidders pass:

auctionId as source.tid bidderRequest[i].transationId as imp[i].ext.tid

Sure thing

@GLStephen
Copy link
Collaborator Author

@patmmccann updates have been made

@ChrisHuie ChrisHuie merged commit fcd1e3c into prebid:master Oct 18, 2022
JacobKlein26 pushed a commit to nextmillenniummedia/Prebid.js that referenced this pull request Feb 9, 2023
@GLStephen @JacobKlein26
PubWise Bid Adapter: clean up and updates to adUnit parsing (prebid#9066
02545cb 
)

* add pubwise bid adpater updates

* Update pubwiseBidAdapter_spec.js

* updates for feedback from review, adding imp.ext.tid and source.tid from appropriate locations
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this pull request May 23, 2023
@GLStephen @jorgeluisrocha
PubWise Bid Adapter: clean up and updates to adUnit parsing (prebid#9066
e017d6d 
)

* add pubwise bid adpater updates

* Update pubwiseBidAdapter_spec.js

* updates for feedback from review, adding imp.ext.tid and source.tid from appropriate locations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patmmccann patmmccann patmmccann left review comments

@ChrisHuie ChrisHuie ChrisHuie approved these changes

Assignees

@patmmccann patmmccann

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GLStephen @patmmccann @ChrisHuie