Magnite Analytics Adapter: New Adapter #9068
Conversation
…niteAnalyticsAdapter
fix clashing rubicon configs in tests
…into magniteAnalyticsAdapter
so use "requestId"
…niteAnalyticsAdapter
robertrmartinez
changed the title
modules/rubiconAnalyticsAdapter.js
Outdated
| @@ -799,7 +804,7 @@ let rubiconAdapter = Object.assign({}, baseAdapter, { | |||
| } | |||
|
|
|||
| let bid = auctionEntry.bids[args.requestId]; | |||
| // If floor resolved gptSlot but we have not yet, then update the adUnit to have the adSlot name | |||
| // If floor rot besolved gptSlut we have not yet, then update the adUnit to have the adSlot name | |||
There was a problem hiding this comment.
I think there's an error here
There was a problem hiding this comment.
@robertrmartinez don't forget about this one
| } | ||
| }; | ||
| } | ||
| resetRubiConf(); |
There was a problem hiding this comment.
can yoy explain why there was the need for this addition?
There was a problem hiding this comment.
it is for tests to be able to start clean, and I figured instead of defaulting and then having a function reset those defaults, better to just have a function to set defaults and call it at load time.
But yeah, tests use it to clean the conf between tests.
| } | ||
|
|
||
| const subscribeToGamSlots = () => { | ||
| window.googletag.pubads().addEventListener('slotRenderEnded', event => { |
There was a problem hiding this comment.
why not use slotResponseReceived; not a change request, just curious
There was a problem hiding this comment.
I actually do not know! This is what we have been using in the old Rubicon Analytics Adapter.
What are the differences between the two? I will go look at documentation but curious as to your thoughts.
There was a problem hiding this comment.
Looks like slotResponseReceived does not have the gam ID's included. At least from the documentation standpoint.
There was a problem hiding this comment.
it does though, they are just undocumented
There was a problem hiding this comment.
also, annoyingly, yieldgroupid and companyid are not documented
There was a problem hiding this comment.
does it really?
I looked and it did not pass it, will double check, if so the slotResponseReceived is def better as it fires earlier!
There was a problem hiding this comment.
@patmmccann On my test page I get the following:
Add delay processing to Bid Won
|
Hi @patmmccann the review is ok on my side but since you are also listed in reviewers I'd wait for your approval too. |
|
@ChrisHuie Want to give this a once over and merge please? @patmmccann as well if you want to! |
* stash * mgni analytics done? * test not finished * remove log * get rid of console log * pass render transaction id * add bid Id * fix bidder done * fix tests * Handle PPI elementids case * added lots of test + minor fixes * implement Michele review comments fix clashing rubicon configs in tests * michele fixes * sometimes bidWons do not have "bidId" so use "requestId" * add logs so we can debug on page * handle currency conversion errors better * bug fixes * time since page load * Magnite MD * Move session to auction init * Change adUnitMap to transactionId Add delay processing to Bid Won * oops
* stash * mgni analytics done? * test not finished * remove log * get rid of console log * pass render transaction id * add bid Id * fix bidder done * fix tests * Handle PPI elementids case * added lots of test + minor fixes * implement Michele review comments fix clashing rubicon configs in tests * michele fixes * sometimes bidWons do not have "bidId" so use "requestId" * add logs so we can debug on page * handle currency conversion errors better * bug fixes * time since page load * Magnite MD * Move session to auction init * Change adUnitMap to transactionId Add delay processing to Bid Won * oops
Type of change
Description of change
New Analytics Adapter for MAGNITE.
This new analytics adapter will sunset the Rubicon Analytics Adapter. Possible in 8.X or 9.X depending on timing. For now we will leave both in.
DOCS PR: prebid/prebid.github.io#4056