Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMX: Ignore empty "adUnitId" parameter #9071

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

nickjacob
Copy link
Collaborator

Type of change

  • Bugfix
  • [X ] Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes

Description of change

The amxBidAdapter takes an optional "adUnitId" parameter, defaulting to the bid request "adUnitCode". Because some wrappers send an empty string when the publisher intends to send an empty/nonexistent value (e.g. use the default), we should treat the empty string as non-existent/default to adUnitCode.

@nickjacob nickjacob changed the title XMX: Ignore empty "adUnitId" parameter AMX: Ignore empty "adUnitId" parameter Oct 4, 2022
@ChrisHuie ChrisHuie self-assigned this Oct 4, 2022
@ChrisHuie ChrisHuie merged commit 0c68e20 into prebid:master Oct 4, 2022
JacobKlein26 pushed a commit to nextmillenniummedia/Prebid.js that referenced this pull request Feb 9, 2023
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants