-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smaato Bid Adapter: Native support #9089
Smaato Bid Adapter: Native support #9089
Conversation
modules/smaatoBidAdapter.js
Outdated
@@ -342,6 +426,55 @@ function createVideoImp(bidRequest, videoMediaType) { | |||
}; | |||
} | |||
|
|||
function createNativeImp(bidRequest, nativeMediaType) { | |||
const mainImageSize = nativeMediaType.image.sizes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation for it is still in progress, so the timing of this PR is a bit unfortunate, but prebid now supports native ORTB out of the box with very little adapter code required:
bidRequest.nativeOrtbRequest
should be an object very similar to yourcreateNativeImp(..).native
- bids returned by
interpretResponse
can use the ORTB native response directly ({native: {ortb: JSON.parse(bid.adm)}}
)
@musikele FYI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you, i'm having a look and will update the PR
- update to ortb native
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code LGTM, but beware that I am not able to properly test this with the example config in your md file. If I use this:
{
"bidder": "smaato",
"params": {
"publisherId": "1100042525",
"adspaceId": "130563103"
}
}
the endpoint replies with 204, no content (and no bid). In particular I wanted to verify the server response because this code expects {native: [ORTB native response]}
, which is different from what I'm used to - the ORTB native response at the top level.
i can confirm that (non standard) |
* PREB-36 [Prebid.js] Native support * PREB-36 [Prebid.js] Native support - update to ortb native Co-authored-by: Ruslan Sibgatullin <ruslan.sibgatullin@smaato.com> Co-authored-by: Bernhard Pickenbrock <bernhard.pickenbrock@smaato.com>
* PREB-36 [Prebid.js] Native support * PREB-36 [Prebid.js] Native support - update to ortb native Co-authored-by: Ruslan Sibgatullin <ruslan.sibgatullin@smaato.com> Co-authored-by: Bernhard Pickenbrock <bernhard.pickenbrock@smaato.com>
Type of change
Feature
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Description of change
Adding native support for Smaato bid adapter
Other information
prebid/prebid.github.io#4064