Freewheel-SSP Bid Adapter: add alias, update local param, and other additions #9093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@patmmccann can you please review? Thanks. |
patmmccann
reviewed
Oct 10, 2022
modules/freewheel-sspBidAdapter.js
Outdated
| // TODO: is 'page' the right value here? | ||
| var location = bidderRequest?.refererInfo?.page; | ||
|
|
||
| var location = (bidderRequest && bidderRequest.refererInfo) ? bidderRequest.refererInfo.referer : getTopMostWindow().location.href; |
There was a problem hiding this comment.
What's wrong with page? This appears incorrect
patmmccann
requested changes
Oct 10, 2022
| @@ -387,7 +387,7 @@ describe('freewheelSSP BidAdapter Test', () => { | |||
| ]; | |||
|
|
|||
| let result = spec.interpretResponse(response, request[0]); | |||
| expect(result[0].meta.advertiserDomains).to.deep.equal([]); | |||
| expect(result[0].meta.advertiserDomains).to.deep.equal(''); | |||
ChrisHuie
changed the title
|
@patmmccann the code has been updated. Can you please double check? Thanks. |
patmmccann
approved these changes
Oct 19, 2022
JacobKlein26
pushed a commit
to nextmillenniummedia/Prebid.js
that referenced
this pull request
Feb 9, 2023
…dditions (prebid#9093) * freewheel add schain in the request * FreewheelSSP-Update update the bidder name and advertiserDomain * FreewheelSSP-Update code update * Freewheel-SSP Bid Adapter: code update
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this pull request
May 23, 2023
…dditions (prebid#9093) * freewheel add schain in the request * FreewheelSSP-Update update the bidder name and advertiserDomain * FreewheelSSP-Update code update * Freewheel-SSP Bid Adapter: code update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
freewheelsspadvertiserDomainsiframeEnabledoption ingetUserSyncsmethodOther information