Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Digital adapter: publisher endpoint, addtl consent, syncs #9125

Merged
merged 5 commits into from
Oct 27, 2022

Conversation

jbartek25
Copy link
Contributor

Type of change

  • Bugfix
  • Feature

Description of change

This PR contains 3 changes which are pretty small to justify not splitting them in 3 PRs:

  • add bidders to sync url when extend mode enabled
  • set ConsentedProvidersSettings when extend mode enabled
  • dynamically generated ad server url when publisherId param is set.

Doc PR: prebid/prebid.github.io#4085

- add bidders to sync url when extend mode enabled
- set ConsentedProvidersSettings when extend mode enabled
- dynamically generated AD_SERVER_URL when publisherId available
@jbartek25 jbartek25 changed the title Improve Digital adapter: publisher endpoint, addtl consent, syncs (#14) Improve Digital adapter: publisher endpoint, addtl consent, syncs Oct 18, 2022
@patmmccann patmmccann requested a review from gwhigs October 19, 2022 16:30
@patmmccann
Copy link
Collaborator

@jbartek25 please resolve conflicts

@jbartek25
Copy link
Contributor Author

conflicts with master resolved

@patmmccann patmmccann merged commit e08fea6 into prebid:master Oct 27, 2022
JacobKlein26 pushed a commit to nextmillenniummedia/Prebid.js that referenced this pull request Feb 9, 2023
…ebid#9125)

* Improve Digital adapter: publisher endpoint, addtl consent, syncs (prebid#14)

- add bidders to sync url when extend mode enabled
- set ConsentedProvidersSettings when extend mode enabled
- dynamically generated AD_SERVER_URL when publisherId available

* Code refactored

* Minor changes

Co-authored-by: Faisal Islam <93644923+faisalvs@users.noreply.github.com>
Co-authored-by: Faisal Islam <faisal.islam@vivacomsolutions.com>
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this pull request May 23, 2023
…ebid#9125)

* Improve Digital adapter: publisher endpoint, addtl consent, syncs (#14)

- add bidders to sync url when extend mode enabled
- set ConsentedProvidersSettings when extend mode enabled
- dynamically generated AD_SERVER_URL when publisherId available

* Code refactored

* Minor changes

Co-authored-by: Faisal Islam <93644923+faisalvs@users.noreply.github.com>
Co-authored-by: Faisal Islam <faisal.islam@vivacomsolutions.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants