Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permutive Rtd Provider: convert rubicon video targeting to string #9181

Merged

Conversation

AntonioGargaro
Copy link
Contributor

@AntonioGargaro AntonioGargaro commented Nov 1, 2022

Type of change

  • Bugfix

Description of change

Rubicon requires string targeting information for its video ads. This PR performs this mapping when the params.video property is found for the bid. This property is required for video requests.

The overwrites param for the Permutive RTD is also surfaced in an effort to let users configure targeting uniquely to them.

Other information

N/A

@AntonioGargaro AntonioGargaro force-pushed the make-rubicon-video-cohorts-strings branch from c0fa6d7 to 3b0f235 Compare November 1, 2022 10:42
@AntonioGargaro AntonioGargaro changed the title fix(permutiveRtd): convert video targeting to string Permutive Rtd Module: convert rubicon video targeting to string Nov 1, 2022
@AntonioGargaro AntonioGargaro force-pushed the make-rubicon-video-cohorts-strings branch from 2f80551 to a590c8c Compare November 1, 2022 12:43
@AntonioGargaro AntonioGargaro changed the title Permutive Rtd Module: convert rubicon video targeting to string Permutive Rtd Provider: convert rubicon video targeting to string Nov 1, 2022
@AntonioGargaro AntonioGargaro force-pushed the make-rubicon-video-cohorts-strings branch from a590c8c to 83b43a7 Compare November 1, 2022 12:44
@AntonioGargaro AntonioGargaro marked this pull request as ready for review November 2, 2022 12:07
@ChrisHuie ChrisHuie self-requested a review November 2, 2022 14:59
@ChrisHuie ChrisHuie self-assigned this Nov 2, 2022
@ChrisHuie ChrisHuie merged commit b762241 into prebid:master Nov 2, 2022
@AntonioGargaro AntonioGargaro deleted the make-rubicon-video-cohorts-strings branch November 2, 2022 16:15
JacobKlein26 pushed a commit to nextmillenniummedia/Prebid.js that referenced this pull request Feb 9, 2023
…ebid#9181)

* fix(permutiveRtd): convert video targeting to string

* test(permutiveRtd): convert video targeting for Magmite to string

* docs(permutiveRtd): add `overwrites` parameter
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this pull request May 23, 2023
…ebid#9181)

* fix(permutiveRtd): convert video targeting to string

* test(permutiveRtd): convert video targeting for Magmite to string

* docs(permutiveRtd): add `overwrites` parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants