Appnexus targeting function #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaiminpanchal27
added
needs review
in progress
and removed
in progress
needs review
labels
|
Looks like tests are failing. |
|
@mkendall07 you can take a look now. |
mkendall07
requested changes
Jan 18, 2017
| @@ -0,0 +1,181 @@ | |||
| import { uniques, isGptPubadsDefined, getHighestCpm, adUnitsFilter } from './utils'; | |||
| var bidmanager = require('./bidmanager.js'); | |||
| targeting.setTargeting(targeting.getAllTargeting()); | ||
| }; | ||
|
|
||
| $$PREBID_GLOBAL$$.setTargetingForAn = function() { |
There was a problem hiding this comment.
Let's rename to setTargetingForAst
| @@ -542,6 +542,12 @@ export function isGptPubadsDefined() { | |||
| } | |||
| } | |||
|
|
|||
| export function isApntagDefined() { | |||
There was a problem hiding this comment.
probably makes sense to move this into targeting.js
| //setKeywords supports string and array as value | ||
| if(utils.isStr(targeting[targetId][key]) || utils.isArray(targeting[targetId][key])) { | ||
| var keywordsObj = {}; | ||
| keywordsObj[key] = targeting[targetId][key]; |
There was a problem hiding this comment.
need to check for the hb_adid key and convert to HB_ADID
|
LGTM. |
Walexander
pushed a commit
to MbidIO/Prebid.js
that referenced
this pull request
Mar 6, 2017
* WIP * Targeting code moved to separate file and setTargeting method for appnexus * adding missing file * Code refactoring after review
mp-12301
pushed a commit
to aol/Prebid.js
that referenced
this pull request
Apr 10, 2017
…ebid-official-0.18.0 to release/1.13.0 * commit 'e145489bc5dd6d292cf16e7fe80adfdf991562ac': (27 commits) Add changelog entry. Prebid 0.18.0 Release Add Criteo adapter (prebid#928) add an event that fires when requestBids is called (prebid#939) Xaxis adapter submitted by Daniel hoffmann (prebid#938) Add flash detection to TripleLift adapter (prebid#855) OpenX Adapter: Fixed bug regarding cross-domain iframe support (prebid#931) Emit event when setTargetingForGPTAsync is called (prebid#873) Maintenance/refactor hb deal (prebid#935) Reset hb_* keys only for registered aduniits (prebid#934) update code style - smartyads adapter Catch errors in bidsBackHandler. Also fix test cleanup in pbjs api spec. (prebid#905) Smartyads Adapter (prebid#895) Appnexus targeting function (prebid#920) There are 2 changes- (prebid#913) Adding support for all AST parameters (prebid#923) GumGum adapter - include the bid timeout as `tmax` (prebid#908) Add pixel size (prebid#892) enable postMessage listener for cross-domain iframe support (prebid#885) Add Sharethrough adapter (prebid#865) ...
mp-12301
pushed a commit
to aol/Prebid.js
that referenced
this pull request
Apr 10, 2017
…13.0 to master * commit '7d32ed18c8636d9241ef8b299b6abd885536db69': (27 commits) Add changelog entry. Prebid 0.18.0 Release Add Criteo adapter (prebid#928) add an event that fires when requestBids is called (prebid#939) Xaxis adapter submitted by Daniel hoffmann (prebid#938) Add flash detection to TripleLift adapter (prebid#855) OpenX Adapter: Fixed bug regarding cross-domain iframe support (prebid#931) Emit event when setTargetingForGPTAsync is called (prebid#873) Maintenance/refactor hb deal (prebid#935) Reset hb_* keys only for registered aduniits (prebid#934) update code style - smartyads adapter Catch errors in bidsBackHandler. Also fix test cleanup in pbjs api spec. (prebid#905) Smartyads Adapter (prebid#895) Appnexus targeting function (prebid#920) There are 2 changes- (prebid#913) Adding support for all AST parameters (prebid#923) GumGum adapter - include the bid timeout as `tmax` (prebid#908) Add pixel size (prebid#892) enable postMessage listener for cross-domain iframe support (prebid#885) Add Sharethrough adapter (prebid#865) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Targeting function to add keywords for appnexus added.