Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gumgum throttle #944

Merged
merged 2 commits into from
Feb 2, 2017
Merged

Gumgum throttle #944

merged 2 commits into from
Feb 2, 2017

Conversation

davidmh
Copy link
Contributor

@davidmh davidmh commented Jan 20, 2017

Type of change

  • Feature

Description of change

Throttle for the refresh frequency on the GumGum service.

Behavior:

  • The throttle kicks in only after we win a bid.
  • It works individually by placement and product.
  • The default timeout is 30 seconds, but it can be updated dynamically by publisher/product from within the server response.

No implementation changes are required.

Copy link
Collaborator

@protonate protonate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tests green, confirmed bids back and ad render. Thanks for contribution.

@protonate protonate merged commit 6edab89 into prebid:master Feb 2, 2017
Walexander pushed a commit to MbidIO/Prebid.js that referenced this pull request Mar 6, 2017
* GumGum adapter - set bid throttle by product

* GumGum adapter - consider the placement for the throttle
@davidmh davidmh deleted the gumgum-throttle branch May 23, 2017 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants