Rubicon video support

[snapwich]

Type of change

• Feature

Description of change

Adds video support for the Rubicon adapter. An example adUnit for displaying a video ad should look something like this:

        var videoAdUnit = {
            code: 'example_video_1',
            sizes: [[640,320]],
            mediaType: 'video',
            bids: [
                {
                    bidder: 'rubicon',
                    params: {
                        accountId: "7780",
                        siteId: "87184",
                        zoneId: "412394",
                        userId: "12346",
                        keywords: ["nhl","hockey","goalie"],
                        inventory: {rating:["4-star"], prodtype:["sports"]},
                        visitor: {ucat: ["new"], lastsearch:["hockey"]},
                        position: "atf",
                        video: {

                          'language': 'en',

                          'playerHeight': 320,

                          'playerWidth': 640,

                          'size_id': 201,
                          'aeParams': {"p_aso.video.ext.skip": "1","p_aso.video.ext.skipdelay": "15"}

                        }
                    }
                }
            ]
        };

[snapwich]

I added a small commit to also include the versioning for our adapter requests.

[jaiminpanchal27]

@snapwich currently i am getting swf mediafile in vast response. Can you guys configure it to send any mp4 mediafile.
Actually the test page which i have is only configured for html5.

[dbridges12]

@jaiminpanchal27 can you send me one of the VASTUrls you are receiving as well as your test page which has the adunit you've defined for the test and I'll work through it with you. We can take this offline if you want.

[jaiminpanchal27]

@dbridges12 reach me on jpanchal@appnexus.com

[jaiminpanchal27]

@dbridges12 Please update with the fix for description_url

[dbridges12]

Ok. I'll send in the fix for adserver too. Also my handle is @dbridges12 Thanks

…

Sent from my iPhone

On Feb 2, 2017, at 8:57 AM, jaiminpanchal27 ***@***.***> wrote: @dbabaioff Please update with the fix for description_url — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[mkendall07]

@snapwich @dbridges12
Thanks for making updates to the code. Is the method with the redirect in the DFP URL acceptable for now? Ideally this wouldn't exist, but we implemented that way to due to limitations in DFP.

[dbridges12]

@mkendall07 - we worked around the redirect by passing our impression id in the description_url field and using a macro to insert it into our main site - that way dfp returns a wrapper with our site directly embedded.

[mkendall07]

Ah right. Ok I would like to propose a change.
Since adding impression_id to bid.vastUrl feels kind of ugly, I would like to instead use a new field such as bid.descriptionUrl that can be populated with a VAST URL or an impression ID or anything (up to the Bidder's implementation). This field would then be used in the pbjs.buildMasterVideoTagFromAdserverTag to construct the macro.

Thoughts?
@snapwich
@dbridges12
@jaiminpanchal27

Edit: we'd need to update appnexusAst if we make this change.

[dbridges12]

@mkendall07 - I'm all for it. Let me know when your ready.

[jaiminpanchal27]

@dbridges12 one of the test is failing for your spec. Check travis failed build.

[dbridges12]

We caught the failed test - waiting to make the change matt suggested before resubmitting

[mkendall07]

Cool. @jaiminpanchal27 can you put up a PR with those changes for core + appnexus?

[mkendall07]

Can rebase off master now with the change.

[dbridges12]

Latest commit incorporates the bid.descriptionUrl field in the rubicon adaptor.

Also fixes a small bug in the adserver.js file where the correlator was not being passed in the arguments to DFP.

[jaiminpanchal27]

Looks good. Merging.