Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Triplelift Bid Adapter: set networkId in response #9545

Merged
merged 23 commits into from
Feb 15, 2023
Merged

Triplelift Bid Adapter: set networkId in response #9545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
33e8fdf
prioritize topmostlocation
nllerandi3lift Oct 31, 2022
667fb2e
adds test for topmostlocation / referrer
nllerandi3lift Oct 31, 2022
6e5c0b0
cleanup
nllerandi3lift Oct 31, 2022
751256a
Merge pull request #62 from triplelift-internal/TL-323522-topmostloca…
nllerandi3lift Oct 31, 2022
3788611
delete param after test
nllerandi3lift Oct 31, 2022
d082122
Merge branch 'prebid:master' into master
patrickloughrey Nov 29, 2022
b92cf26
TL-32803: Update referrer logic
patrickloughrey Nov 29, 2022
f2685be
TL-32803: Update referrer logic
patrickloughrey Nov 30, 2022
c969022
Merge pull request #64 from triplelift-internal/TL-32803-Update-refer…
patrickloughrey Nov 30, 2022
f18813d
Merge branch 'prebid:master' into master
patrickloughrey Nov 30, 2022
50d2466
Merge branch 'prebid:master' into master
patrickloughrey Jan 12, 2023
9f466ae
Merge branch 'prebid:master' into master
patrickloughrey Jan 18, 2023
f361ed2
Merge branch 'prebid:master' into master
patrickloughrey Jan 23, 2023
f0e8f63
TL-34204: Add support for GPP
patrickloughrey Jan 23, 2023
26fe5f5
Merge pull request #66 from triplelift-internal/TL-34204-GPP-Feature
patrickloughrey Jan 24, 2023
2060fbb
Merge branch 'prebid:master' into master
patrickloughrey Jan 24, 2023
b564323
Merge branch 'prebid:master' into master
patrickloughrey Feb 10, 2023
2ba7832
Merge branch 'prebid:master' into master
patrickloughrey Feb 13, 2023
db12152
TL-34944: Add logic to pass networkId back in the bid response
patrickloughrey Feb 13, 2023
3183882
TL-34944: Add logic to pass networkId back in the bid response
patrickloughrey Feb 14, 2023
fa6ec28
TL-34944: Add logic to pass networkId back in the bid response
patrickloughrey Feb 14, 2023
bf61827
few more tests
nllerandi3lift Feb 15, 2023
6b55848
Merge pull request #69 from triplelift-internal/TL-34944-Meta-NetworkId
patrickloughrey Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions modules/tripleliftBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,6 +436,10 @@ function _buildResponseObject(bidderRequest, bid) {
if (bid.tl_source && bid.tl_source == 'tlx') {
bidResponse.meta.mediaType = 'native';
}

if (creativeId) {
bidResponse.meta.networkId = creativeId.slice(0, creativeId.indexOf('_'));
}
};
return bidResponse;
}
Expand Down
7 changes: 7 additions & 0 deletions test/spec/modules/tripleliftBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1437,6 +1437,13 @@ describe('triplelift adapter', function () {
expect(result[0].meta.advertiserDomains[1]).to.equal('internetalerts.org');
expect(result[1].meta).to.not.have.key('advertiserDomains');
});

it('should include networkId in the meta field if available', function () {
let result = tripleliftAdapterSpec.interpretResponse(response, {bidderRequest});
expect(result[1].meta.networkId).to.equal('10092');
expect(result[2].meta.networkId).to.equal('5989');
expect(result[3].meta.networkId).to.equal('5989');
});
});

describe('getUserSyncs', function() {
Expand Down