CleanMediaNet Bid Adapter : add userid support and update testing #9608

CleanMediaNet · 2023-02-28T21:02:14Z

Type of change

[X ] Build related changes

Description of change

Adapter Schain and user id support has been added
MD setup updated
test file updated

This reverts commit f7d3e50.

This reverts commit 8612306.

Fawke · 2023-03-06T07:59:44Z

modules/cleanmedianetBidAdapter.js

-      let url = bidderRequest.refererInfo.page;
-
+      const {adUnitCode, auctionId, mediaTypes, params, sizes, transactionId} = bidRequest;
+      const baseEndpoint = params['rtbEndpoint'] || ENDPOINTS['cleanmedianet'];


Can you please enforce the value from params[rtbEndpoint] is using https: protocol.

Fawke

Hi @CleanMediaNet,

This change looks fine. I just added a small comment to ensure that the endpoint stays https.
Apart from that, I'm trying to re-trigger the circle ci tests, but having some issues.

Post a successful re-run of the Circle CI unit tests, I'll merge this.

CleanMediaNet · 2023-03-06T21:33:01Z

Hi @CleanMediaNet,

This change looks fine. I just added a small comment to ensure that the endpoint stays https. Apart from that, I'm trying to re-trigger the circle ci tests, but having some issues.

Post a successful re-run of the Circle CI unit tests, I'll merge this.

I'm also having trouble getting Circle CI to re-run, it instantly fails. Do you have any advice or should I do a fresh fork and re-submit?
It all tests great locally but the Circle CI test is not running it, any advice or direction would be appreciated.
Thanks

ChrisHuie · 2023-03-07T16:23:42Z

Hi @CleanMediaNet,
This change looks fine. I just added a small comment to ensure that the endpoint stays https. Apart from that, I'm trying to re-trigger the circle ci tests, but having some issues.
Post a successful re-run of the Circle CI unit tests, I'll merge this.

I'm also having trouble getting Circle CI to re-run, it instantly fails. Do you have any advice or should I do a fresh fork and re-submit? It all tests great locally but the Circle CI test is not running it, any advice or direction would be appreciated. Thanks

Just tried kicking off myself but it didn't work which is strange. Usually this problem comes up because you are following a fork of the project in CircleCI instead of the main Prebid.js repo. You can find the projects you follow on the left and side of circleci. Unfollowing your fork should fix the issue

CleanMediaNet · 2023-03-07T22:21:03Z

It is un-followed.

CleanMediaNet · 2023-03-07T22:22:04Z

It is un-followed.

Fawke · 2023-03-09T11:00:39Z

@CleanMediaNet I was having another look at the PR today, and wanted to approve it, but I still see that you haven't added a check to make sure the endpoint url coming from params[rtbEndpoint] is always https.

I've run the tests locally, and they're all passing, so I don't think we'd need circle ci checks for this. If @ChrisHuie can somehow make it work, then it's great, otherwise, it's fine to merge post the change I suggested above.

EndPoint Update

CleanMediaNet · 2023-03-09T21:13:59Z

Fawke

@Fawke, I've updated to only use the HTTPS endpoint and not allow an endpoint to be passed. Let me know if there is anything else you see that needs updated.

CleanMediaNet · 2023-03-20T18:05:16Z

Fawke

@Fawke, I've updated to only use the HTTPS endpoint and not allow an endpoint to be passed. Let me know if there is anything else you see that needs updated.

@Fawke is there anything else we need to do to get the adapter to show up on the download page?

* upstream/master: Prebid Server adapter: fledge support (prebid#9342) Taboola Bid Adapter: resolve AUCTION_PRICE macro (prebid#9735) Revert "IntentIQ Analytics Module : initial release (prebid#9322)" (prebid#9734) IntentIQ Analytics Module : initial release (prebid#9322) Increment version to 7.44.0-pre Prebid 7.43.0 release Core: allow restriction of cookies / localStorage through `bidderSettings.*.storageAllowed` (prebid#9660) Add 9 Dots Media alias (prebid#9699) Smaato: Adapters that accept geolocation data from bid parameters should also accept it from ortb2.(device|user).geo (prebid#9676) (prebid#9725) Adloox AdServer Video : lengthen test timeouts (prebid#9728) RTBHouse Bid Adapter: change `source.tid` to contain `auctionId` and populate imp-level `ext.tid` (prebid#9726) chore: update `getAudiencesAsBidderOrtb2` implementation and test (prebid#9720) CORE: allow to disable setting the pbjs global variable (prebid#9568) Display.io Bid Adapter: ad request parameters renaming, user session saving (prebid#9553) CORE: add bid to winningBids when marking as used (prebid#9612) Concert Bid Adapter: enable support for GPP consent and remove user sync (prebid#9700) Sonobi Bid Adapter: add IntentIq Id (prebid#9649) added fix and support for multibid module (prebid#9602) Update Permutive RTD documentation (prebid#9697) Adkernel Bid Adapter: add adlive.io alias (prebid#9714) FPD Enrichment: use low entropy method by default to fetch user agent data (prebid#9711) GumGum Bid Adapter : send gpp data in bidrequest (prebid#9707) Adagio Bid Adapter : add new params `splitKeyword` and `dl` to bidRequest payload (prebid#9694) fix lint and test failures Increment version to 7.43.0-pre Prebid 7.42.0 release Fluct Bid Adapter: add user sync support (prebid#9651) VIS.X fix onTimeout data (prebid#9657) ShowHeroes Bid Adapter: added support for USP (prebid#9681) Core: improve FPD enrichment (prebid#9659) changed the URL (prebid#9698) Permutive RTD Module: migrate appnexus to ortb2 (prebid#9630) Disable describe.only and it.only (prebid#9693) DistroScale bidder enhancement (prebid#9641) minutemediaplus Bid Adapter - pass gpp, sua and bid data to server. (prebid#9637) LiveIntent UserId module: update LiveConnect dependency (prebid#9672) Criteo Bid Adapter: reinforce adomain type in case of missmatch (prebid#9687) SmartyTech Bid Adapter : add size parameters (prebid#9692) Revert "Nativo Bid Adapter: adding UserId support (prebid#9583)" (prebid#9691) GDPR consent management: accept static config without `getTCData` (prebid#9664) Kulturemedia Bid Adapter: New Adapter (prebid#9613) Nativo Bid Adapter: adding UserId support (prebid#9583) Underdog Media Bid Adapter: Switch request to method to POST (prebid#9547) ZetaGlobalSsp: provide schain (prebid#9678) Next Millennium Bid Adapter : added `imp[].id` required parameter for openrtb 2.5 request. (prebid#9675) Increment version to 7.42.0-pre Prebid 7.41.0 release DFP video adserver module: set `description_url` to pub's URL by default; do not skip setting it if `cache.url` is set (prebid#9665) support the timeout parameter in the conversant adapter (prebid#9673) Browsi Bid Adapter: initial release (prebid#9562) feat(permutiveRtd): add `ix` and custom cohort `ortb2.user.data` (prebid#9631) Freewheel SSP Adapter: add prebid version in ad request (prebid#9667) Yandex Bid Adapter: (prebid#9604) Bump webpack from 5.74.0 to 5.76.0 (prebid#9668) Deleted the default empty string from userConsent argument in the module's init-function. (prebid#9663) AdUp Technology bid adapter: avoid modification of bid request (prebid#9656) NoBid Bid Adapter: support for Floors (prebid#9635) Freewheel SSP Bid Adapter : support userIdAsEids (prebid#9655) Missena: add userEids, add network and cpm to tracking (prebid#9645) IX Bid Adapter: update additional consent field (prebid#9650) Aduptech Bid Adapter : add GVLID (prebid#9658) Core: make video cache timeout configurable (prebid#9578) Delete flocIdSystem.js (prebid#9652) TheMediaGrid Bid Adapter : support gpp (prebid#9629) Stv Bid Adapter : initial adapter release (prebid#9533) CleanMediaNet Bid Adapter : add userid support and update testing (prebid#9608) Update creative.html (prebid#9648) PubWise Bid Adapter: support video and improve tests (prebid#9576) Increment version to 7.41.0-pre Prebid 7.40.0 release Rubicon Bid Adapter: add size 1x2 (prebid#9644) main>modules\neuwoRtdProvider.js > apiUrl format handling improved, removed unnecessary parameter integrationExamples\gpt\neuwoRtdProvider_example.html > fixed render-step handling on warning (prebid#9646) Core: fix native render when adUnits defines `mediaTypes.native.ortb` but adapter replies with "legacy" native bid (prebid#9638) kueezRtb Bid Adapter: pass sua data to server. (prebid#9643) update Mediago & Discovery BidAdapter:remove size filter (prebid#9585) Permutive RTD Module: migrate magnite to ortb2 (prebid#9555) Vidazoo Bid Adapter: pass sua params. (prebid#9636) ADJS-1271-send-envelope-param-for-lexicon (prebid#9634) Nexx360 Bid Adapter: native support added and ortbConverter usage (prebid#9626) PBjs Core: do not rely on an extendable `window.Promise` (prebid#9558) TheMediaGrid Bid Adapters : do not use jwp segments from bid.rtd field (prebid#9627) read video size from playerSize (prebid#9625) Lemma Digital Bid Adapter : initial adapter release (prebid#9532) smallfix on response validation (prebid#9623) Updated adf adapter to support native with type; use ortb request for natives (prebid#9616) kargo adapter - adding prebid version to requests (prebid#9620) Rubicon bid adapter: remove pchain support (prebid#9621) trigger build revert tag out markWinningBidAsUsed entirely remove unnecessary feature tag tag out ORTB video conversion utils tag out video-related code in native.js tag out video-related code in renderAd replace callPrebidCache with getHook result tag out adpod-related logic Define "VIDEO" compile time feature flag

…ebid#9608) * Update cleanmedianetBidAdapter.js * Update cleanmedianetBidAdapter.md * Revert "Update cleanmedianetBidAdapter.md" This reverts commit f7d3e50. * Revert "Update cleanmedianetBidAdapter.js" This reverts commit 8612306. * Update cleanmedianetBidAdapter_spec.js * Update cleanmedianetBidAdapter.md * Update cleanmedianetBidAdapter.js * Updated config.yml * Updated config.yml * kick off tests * Update cleanmedianetBidAdapter.md * Update cleanmedianetBidAdapter.js EndPoint Update * Update cleanmedianetBidAdapter.js --------- Co-authored-by: Moshe Moses <moshe.moses@gmail.com> Co-authored-by: moses <moses@gamoshi.com> Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>

CleanMediaNet and others added 8 commits February 28, 2023 06:53

Update cleanmedianetBidAdapter.js

8612306

Update cleanmedianetBidAdapter.md

f7d3e50

Merge branch 'prebid:master' into master

6a12b51

Revert "Update cleanmedianetBidAdapter.md"

9bb98a9

This reverts commit f7d3e50.

Revert "Update cleanmedianetBidAdapter.js"

034f713

This reverts commit 8612306.

Update cleanmedianetBidAdapter_spec.js

1cce555

Update cleanmedianetBidAdapter.md

8cf1b01

Update cleanmedianetBidAdapter.js

9afb74d

jsnellbaker requested a review from Fawke March 1, 2023 14:44

jsnellbaker assigned Fawke Mar 1, 2023

jsnellbaker added the maintenance label Mar 1, 2023

Fawke reviewed Mar 6, 2023

View reviewed changes

CleanMediaNet added 2 commits March 6, 2023 15:49

Updated config.yml

616cca5

Updated config.yml

40f90e2

ChrisHuie changed the title ~~CleanMediaNet bidder update~~ CleanMediaNet Bid Adapter : bidder update Mar 7, 2023

ChrisHuie changed the title ~~CleanMediaNet Bid Adapter : bidder update~~ CleanMediaNet Bid Adapter : add userid support and update testing Mar 7, 2023

kick off tests

3e5fe94

CleanMediaNet added 2 commits March 9, 2023 16:05

Update cleanmedianetBidAdapter.md

4177123

Update cleanmedianetBidAdapter.js

858bdd1

EndPoint Update

Update cleanmedianetBidAdapter.js

f767fd3

Fawke self-requested a review March 10, 2023 09:27

Fawke approved these changes Mar 10, 2023

View reviewed changes

Fawke merged commit ec5e97d into prebid:master Mar 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CleanMediaNet Bid Adapter : add userid support and update testing #9608

CleanMediaNet Bid Adapter : add userid support and update testing #9608

CleanMediaNet commented Feb 28, 2023

Fawke Mar 6, 2023

Fawke left a comment

CleanMediaNet commented Mar 6, 2023

ChrisHuie commented Mar 7, 2023

CleanMediaNet commented Mar 7, 2023

CleanMediaNet commented Mar 7, 2023

Fawke commented Mar 9, 2023

CleanMediaNet commented Mar 9, 2023

CleanMediaNet commented Mar 20, 2023

CleanMediaNet Bid Adapter : add userid support and update testing #9608

CleanMediaNet Bid Adapter : add userid support and update testing #9608

Conversation

CleanMediaNet commented Feb 28, 2023

Type of change

Description of change

Fawke Mar 6, 2023

Choose a reason for hiding this comment

Fawke left a comment

Choose a reason for hiding this comment

CleanMediaNet commented Mar 6, 2023

ChrisHuie commented Mar 7, 2023

CleanMediaNet commented Mar 7, 2023

CleanMediaNet commented Mar 7, 2023

Fawke commented Mar 9, 2023

CleanMediaNet commented Mar 9, 2023

CleanMediaNet commented Mar 20, 2023