OpenX bid adapter: support optional video compilation #9708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbcrute
changed the title
mbcrute
force-pushed
the
openx-support-optional-video-compilation
branch
from
6928aaf to
e690855
Compare
mbcrute
force-pushed
the
openx-support-optional-video-compilation
branch
2 times, most recently
from
3e65381 to
c360b1d
Compare
|
Fyi, I will be out and unable to review this pr until Thursday |
mbcrute
force-pushed
the
openx-support-optional-video-compilation
branch
from
c360b1d to
c816cef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Feature
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Description of change
This PR builds off of #9543 adding support for optional video compilation to the OpenX bid adapter.
PLEASE NOTE
After rebasing from
masterit looks like there's a couple of unrelated tests timing out (the same tests from #9728). I bumped the timeouts on those tests in this commit 582a043 in an effort to get a green build.Other information
TESTING: We have been testing these changes in our fork of Prebid on our website for over a month. We have seen no significant changes in any of our metrics (CPM, CTR, viewability, etc).