Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenX bid adapter: support optional video compilation #9708

Closed

Conversation

mbcrute
Copy link
Contributor

@mbcrute mbcrute commented Mar 24, 2023

Type of change

  • Feature

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

Description of change

This PR builds off of #9543 adding support for optional video compilation to the OpenX bid adapter.

PLEASE NOTE

After rebasing from master it looks like there's a couple of unrelated tests timing out (the same tests from #9728). I bumped the timeouts on those tests in this commit 582a043 in an effort to get a green build.

Other information

TESTING: We have been testing these changes in our fork of Prebid on our website for over a month. We have seen no significant changes in any of our metrics (CPM, CTR, viewability, etc).

@mbcrute mbcrute changed the title Openx support optional video compilation OpenX bid adapter: support optional video compilation Mar 24, 2023
@mbcrute mbcrute force-pushed the openx-support-optional-video-compilation branch from 6928aaf to e690855 Compare March 30, 2023 13:11
@mbcrute mbcrute marked this pull request as ready for review March 30, 2023 14:57
@ChrisHuie ChrisHuie requested a review from spotxslagle March 30, 2023 19:13
@mbcrute mbcrute force-pushed the openx-support-optional-video-compilation branch 2 times, most recently from 3e65381 to c360b1d Compare April 3, 2023 13:58
@spotxslagle
Copy link
Contributor

Fyi, I will be out and unable to review this pr until Thursday

@mbcrute mbcrute force-pushed the openx-support-optional-video-compilation branch from c360b1d to c816cef Compare April 3, 2023 19:29
Copy link
Contributor

@spotxslagle spotxslagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bwschmidt
Copy link
Contributor

@mbcrute FYI OpenX has updated our default adapter to the Ortb version which has the video compilation features, see #9794

@patmmccann patmmccann closed this Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants