-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yahoo ConnectId UserID Module: explicit storage management #9716
Merged
ChrisHuie
merged 8 commits into
prebid:master
from
slimkrazy:feature/yahoo-connectid-explicit-storage-management
Apr 12, 2023
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ecae62c
Explicitly manage storage of ConnectID
353ff75
Merge branch 'master' into feature/yahoo-connectid-explicit-storage-m…
bea63e6
Addressed initial PR feedback
262647a
Documentation update
de14f3f
Merge branch 'master' into feature/yahoo-connectid-explicit-storage-m…
32670fd
Address consent logic issues
0f58392
Prevent storage of empty object response from UPS
a29e03c
Change storage key to match module name.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a question about what I'm doing here. I've noticed the documentation here that states that if we return an
id
key, then the value will be stored in storage. It also makes it seem that bothid
andcallback
are optional. How can I prevent Prebid core from storing the value in storage, as we're already doing this ourselves, yet continue to allow the core logic to access the data?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After stepping away from this, I think I can answer this question myself: We need to explicitly state in our documentation that the storage config should be omitted, then Prebid core will not store the user ID value itself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jlukas79 would you mind confirming this for me?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jlukas79 - I'm just making another change. Spotted that we're looking for the consent data in the wrong place. Should update the PR shortly, please do not merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jlukas79 - Please review and merge whenever you are ready.