Multiple modules: use `ortb2.source.tid` and `ortb2Imp.ext.tid` instead of auctionId/transactionId #9969

dgirardi · 2023-05-18T16:44:09Z

Type of change

Feature

Description of change

This refactors most adapters to use IDs from ortb2 / ortb2Imp instead of directly picking up auctionId / transactionId, to facilitate turning them off for #9781

In many cases adapters use them in a way that is not trivial to refactor in this way (see this comment); I have left a note mentioning the issue.

…ad of auction/transaction IDs

patmmccann · 2023-05-18T18:04:21Z

List of to-dos:

modules/adagioBidAdapter.js: modules/addefendBidAdapter.js: modules/adqueryBidAdapter.js: modules/aduptechBidAdapter.js: modules/adWMGBidAdapter.js: modules/aidemBidAdapter.js: modules/alkimiBidAdapter.js: modules/amxBidAdapter.js: modules/apstreamBidAdapter.js: modules/audiencerunBidAdapter.js: modules/beopBidAdapter.js: modules/beopBidAdapter.js: modules/betweenBidAdapter.js: modules/browsiBidAdapter.js: modules/carodaBidAdapter.js: modules/connectadBidAdapter.js: modules/criteoBidAdapter.js: modules/datablocksBidAdapter.js: modules/discoveryBidAdapter.js: modules/dspxBidAdapter.js: modules/glomexBidAdapter.js: modules/gridBidAdapter.js: modules/holidBidAdapter.js: modules/innityBidAdapter.js: modules/interactiveOffersBidAdapter.js: modules/iqmBidAdapter.js: modules/ixBidAdapter.js: modules/jixieBidAdapter.js: modules/kargoBidAdapter.js: modules/koblerBidAdapter.js: modules/kueezRtbBidAdapter.js: modules/lassoBidAdapter.js: modules/livewrappedBidAdapter.js: modules/logicadBidAdapter.js: modules/loglyliftBidAdapter.js: modules/malltvBidAdapter.js: modules/mediaforceBidAdapter.js: modules/mediagoBidAdapter.js: modules/medianetBidAdapter.js: modules/mediasquareBidAdapter.js: modules/minutemediaBidAdapter.js: modules/minutemediaplusBidAdapter.js: modules/newspassidBidAdapter.js: modules/nextMillenniumBidAdapter.js: modules/onetagBidAdapter.js: modules/optidigitalBidAdapter.js: modules/orbidderBidAdapter.js: modules/otmBidAdapter.js: modules/ozoneBidAdapter.js: modules/pixfutureBidAdapter.js: modules/prismaBidAdapter.js: modules/proxistoreBidAdapter.js: modules/pubmaticBidAdapter.js: modules/relaidoBidAdapter.js: modules/resetdigitalBidAdapter.js: modules/revcontentBidAdapter.js: modules/richaudienceBidAdapter.js: modules/riseBidAdapter.js: modules/rtbsapeBidAdapter.js: modules/showheroes-bsBidAdapter.js: modules/slimcutBidAdapter.js: modules/smarticoBidAdapter.js: modules/sspBCBidAdapter.js: modules/stroeerCoreBidAdapter.js: modules/sublimeBidAdapter.js: modules/talkadsBidAdapter.js: modules/tappxBidAdapter.js: modules/teadsBidAdapter.js: modules/theAdxBidAdapter.js: modules/tpmnBidAdapter.js: modules/truereachBidAdapter.js: modules/vdoaiBidAdapter.js: modules/vidazooBidAdapter.js: modules/videoheroesBidAdapter.js: modules/videoreachBidAdapter.js: modules/vlybyBidAdapter.js: modules/voxBidAdapter.js: modules/winrBidAdapter.js: modules/xeBidAdapter.js: modules/yieldmoBidAdapter.js: // TODO: fix auctionId leak: #9781
// TODO: fix auctionId/transactionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId/transactionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix transactionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: this logic should stop relying on transactionId always being available; see: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId/transactionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId & transactionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId/transactionID leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix transactionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId/transactionId leak: #9781
// TODO: fix auctionId/transactionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix transactionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix transactionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix transactionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781
// TODO: fix auctionId leak: #9781

patmmccann · 2023-05-22T13:31:04Z

modules/appnexusBidAdapter.js

@@ -961,6 +961,7 @@ function bidToTag(bid) {
    tag['banner_frameworks'] = bid.params.frameworks;
  }

+  // TODO: why does this need to iterate through every ad unit?


@jsnellbaker icymi

@dgirardi I think the idea was to look at the adUnit as the source of truth here, since PBJS (at the time at least, not sure if it's still true today) could create a backup mediaTypes object in the bid object if the mediaTypes field was undefined in the setup. In that scenario, we didn't want to pass along the ad_type field if the publisher didn't define it in their adUnit. (see #4065 for the original PR from ~4 years ago).

There's probably other ways this can be done nowadays, so feel free to give it a try if it will help clean things up for the rest of the project.

I don't understand the reasoning. If prebid says that the default mediatype is banner, why would appnexus want to contradict that? and why would only appnexus want to contradict that? I'd expect all bidders to give me a banner if that's what I am (implicitly) asking for.

Besides that, there are some other scenarios where this would behave surprisingly I think. it's possible to set up a multiformat adUnit and use sizemapping to turn off some mediatypes for some form factors; for example banner & video but banner is disabled on mobile. Granted it's not very likely, but this logic would circumvent it.

I think this was done originally due to multi-format requests. There's logic in our system where if certain fields are left empty on the request, then the corresponding value in the adserver UI would take-over - which includes the mediatype values. So if a publisher had left it out on their adUnit, then their placement with banner + video + native could use all 3 types - instead of being narrowed down to banner due to PBJS' defaults.

I'm not sure if sizemapping was properly considered back then - though sizemapping itself has changed over the years, so maybe it worked before and no one has noticed any edge-case issues (or if they did, they just probably just added the mediaTypes info the adUnit to help the logic).

Given the more heavy reliance on the mediaTypes field though in modern Prebid.js, I don't think most setups would include a setup nowadays where the mediaTypes field is left out intentionally (especially since the banner sizes are set there, instead of in old sizes field). This would probably be a safe bit of logic to change to rely on the bid's mediaType data (if that's the preferred way to go here from your take).

seems like a new issue would work? this pr is merging and unrelated, if i'm reading this correctly

patmmccann · 2023-05-22T13:45:32Z

modules/improvedigitalBidAdapter.js

@@ -150,8 +150,7 @@ export const CONVERTER = ortbConverter({
    mergeDeep(request, {
      id: getUniqueIdentifierStr(),
      source: {
-        // TODO: once https://github.com/prebid/Prebid.js/issues/8573 is resolved, this should be handled by the base ortbConverter logic
-        tid: context.bidRequests[0].auctionId,
+


should this delete line 152 as well?

modules/onetagBidAdapter.js

modules/automatadBidAdapter.js

patmmccann · 2023-05-22T14:13:52Z

modules/riseBidAdapter.js

@@ -407,6 +407,7 @@ function generateGeneralParams(generalObject, bidderRequest) {
    device_type: getDeviceType(navigator.userAgent),
    ua: navigator.userAgent,
    is_wrapper: !!generalBidParams.isWrapper,
+    // TODO: fix auctionId leak: https://github.com/prebid/Prebid.js/issues/9781
    session_id: generalBidParams.sessionId || getBidIdParameter('auctionId', generalObject),


since this sessionid isnt documented at https://docs.prebid.org/dev-docs/bidders/rise.html and can take any format; I think it is likely safe to fallback to bidderRequestId or getuuid here?

modules/shinezBidAdapter.js

patmmccann · 2023-05-22T14:17:48Z

modules/sspBCBidAdapter.js

@@ -104,6 +104,7 @@ const getNotificationPayload = bidData => {

        // basic notification data
        const bidBasicData = {
+          // TODO: fix auctionId leak: https://github.com/prebid/Prebid.js/issues/9781


they define a fallback, seems okay to replace auctionid and leave their fallback in place?

modules/tappxBidAdapter.js

patmmccann · 2023-05-22T14:22:35Z

modules/yieldmoBidAdapter.js

@@ -258,6 +258,7 @@ function addPlacement(request) {
    placementInfo.tid = transactionId;
  }
  if (request.auctionId) {
+    // TODO: fix auctionId leak: https://github.com/prebid/Prebid.js/issues/9781


the fact that this is wrapped in a conditional indicates to me they are okay with nulls.

patmmccann

a few nitpicks

patmmccann

we disagree on a couple edge cases, but I'm okay to let the maintainers resolve to be safe

* Prebid 8: Delete Inskin (#9868) * Delete inskinBidAdapter.js * Delete inskinBidAdapter.md * Delete inskinBidAdapter_spec.js * Prebid 8: Renaming TrustPid User ID module to Utiq (#9872) * feature: Add trustpid user id module * refactor: Update trustpidSystem module, comments and md file * refactor: Update trustpidSystem file to handle domain setting regardless of message events * refactor: Update trustpidSystem module and dependent tests and docs * refactor: Update trustpid undefined checks and returns * tests: Update trustpid tests * docs: Update trustpid docs typo * refactor: Update trustpid acronyms logic * TrustPid: Remove deprecated acronyms logic * Rename TrustPid User ID module to Utiq --------- Co-authored-by: Tomasz Januszek <tomasz@teavaro.com> * RTB-2173: Removing Inmar from Prebid (#8913) * Delete viewability.js (#9873) * Prebid 8: Delete realvu (#9867) * Delete realvuAnalyticsAdapter_spec.js * Delete realvuAnalyticsAdapter.md * Delete realvuAnalyticsAdapter.js * Prebid 8: Delete pubcid (#9869) * Realvu analytics adapter: fix test failures on Edge (#9857) * Realvu analytics adapter: fix test failures on Edge * Remove realVu tests * Delete pubCommonId.js * Delete pubCommonId.md * Delete pubCommonId_spec.js --------- Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> * Prebid 8: Delete openxortb and analytics (#9864) * Delete openxOrtbBidAdapter.js * Delete openxOrtbBidAdapter.md * Delete openxOrtbBidAdapter_spec.js * Update openxBidAdapter_spec.js * Delete openxAnalyticsAdapter.js * Delete openxAnalyticsAdapter.md * Delete openxAnalyticsAdapter_spec.js * Core & multiple modules: populate ortb2.source.tid (#9862) * Core & multiple modules: populate ortb2.source.tid * enable codeql for prebid-8 * Prebid 8: IMDS bid adapter - Rename synacormedia adapter (#9381) * CAPT-252: Synacormedia bid adapter: add tmax to requests based upon provided timeouts. * Re-brand synacormedia adapter to imds (iMedia Digitial Services) * Add alias to synacormedia for backwards compatibility --------- Co-authored-by: Timothy M. Ace <tace@imds.tv> Co-authored-by: Pratik Chavan <pchavan@imds.tv> * Prebid 8: Dead Module removal (#9887) * Delete liveyieldAnalyticsAdapter_spec.js * Delete liveyieldAnalyticsAdapter.md * Delete liveyieldAnalyticsAdapter.js * Delete glimpseBidAdapter.js * Delete glimpseBidAdapter.md * Delete glimpseBidAdapter_spec.js * Prebid 8: Delete GA analytics - universal analytics (#9866) * Delete googleAnalyticsAdapter.js * Delete googleAnalyticsAdapter.md * Delete googleAnalyticsAdapter_spec.js * Prebid 8: Delete zeus (#9874) * Delete zeusPrimeRtdProvider.md * Delete zeusPrimeRtdProvider.js * Prebid 8: remove special augmentation of `auctionInit` event (#9897) * Prebid 8 - deprecate bidder category translation feature in core (#9898) * prebid 8 - deprecate category translation in core * remove storage export and move mapping data to library file * Prebid 8: Delete adgeneration (#9904) * Delete adgenerationBidAdapter_spec.js * Delete adgenerationBidAdapter.md * Delete adgenerationBidAdapter.js * Prebid 8: do not use hardcoded `bidderCode` in resposes from bid adapters (#9905) * Revert "Prebid 8: Delete adgeneration (#9904)" (#9915) This reverts commit ce984b3. * Prebid 8: No mas mass (#9909) * Delete index.html * Delete mass_spec.js * Delete mass.md * Delete mass.js * Prebid 8: Delete emx (#9918) * Delete emx_digitalBidAdapter.js * Delete emx_digitalBidAdapter.md * Delete emx_digitalBidAdapter_spec.js * Remove Rubicon Analytics for Prebid 8 (#9932) * Prebid 8: stop using transactionId as source.tid on ortb2 payloads (#9916) * Update bizzclickBidAdapter.js * Update rubiconBidAdapter.js * Update gothamadsBidAdapter.js * Update luponmediaBidAdapter.js * Update ozoneBidAdapter.js * Update pubmaticBidAdapter.js * Update improvedigitalBidAdapter.js * Update newspassidBidAdapter.js * Update deltaprojectsBidAdapter.js * Update bizzclickBidAdapter.js * Update deltaprojectsBidAdapter.js * Update gothamadsBidAdapter.js * Update luponmediaBidAdapter.js * Update newspassidBidAdapter.js * Update ozoneBidAdapter.js * Update pubmaticBidAdapter.js * Update rubiconBidAdapter.js * Update improvedigitalBidAdapter_spec.js * Update luponmediaBidAdapter_spec.js * Update rubiconBidAdapter_spec.js * Update improvedigitalBidAdapter.js * Update pubmaticBidAdapter.js * Update improvedigitalBidAdapter.js * Update pubmaticBidAdapter.js * Update pubmaticBidAdapter.js * Update pubmaticBidAdapter_spec.js * Update adtrueBidAdapter.js * Update adtrueBidAdapter_spec.js * Update adtrueBidAdapter.js * Update adtrueBidAdapter_spec.js * Update adtrueBidAdapter_spec.js * Do not call onBidViewable, onBidWon, etc for S2S bids (#9919) * Access x_source.tid from ortb2 object (#9960) * Access x_source.tid from ortb2 object * Fix lint errors * Prebid 8: set pubmatic source.tid to auctionId (#9954) * set source.tid to auctionId * removed changes to test page * added support for setting ext.wrapper.transactionId as well * Prebid 8: use `prebid.floors.floorMin` instead of `prebid.floorMin` (#9899) * Prebid 8: remove shutdown company from appnexus aliases (#9977) * Update appnexusBidAdapter.js * Update appnexusBidAdapter.js * add bidResponse before emitting the event BID_RESPONSE, so that the bid is stored in the auction instance when the event is triggered (#9847) * Multiple modules: use `ortb2.source.tid` and `ortb2Imp.ext.tid` instead of auctionId/transactionId (#9969) * adkernel * aidem * beop * bliink * criteo * feedad * grid * kargo * medianet * optidigital * rubicon * smilewanted * Multiple modules: use `ortb2.source.tid` and `ortb2Imp.ext.tid` instead of auction/transaction IDs * tappx * onetag * use bidderRequestId instead of generateUUID * Epsilon - Prebid v8 changes to remove documentation in coding project (#9966) Co-authored-by: aarprice@publicisgroupe.net <aaron.price@epsilon.com> * Prebid 8: pick keywords from FPD in addition to bid params (#9917) * extract appnexus-style keyword logic into its own library * refactor appnexus clones to share keyword logic * pick keywords from ortb2 in addition to bid params * Prebid 8: support sizeMapping for video; extract it into a module (#9893) * Core: support sizeMapping for video * make sizeMapping a module * Magnite Analytics Adapter : do not rely on BID_RESPONSE 0cpm rejected bids (#9933) * Magnite Analytics - Do not rely on BID_RESPONSE for rejected bids * use rejection floor constant! * Remove AOL bid adapter (#10030) Co-authored-by: slimkrazy <sam@slimkrazy.com> * AdTelligent Bid Adapter: remove onefiftytwo alias (#10025) * Smartadserver Bid Adapter: support GPID (#10004) * Smartadserver Bid Adapter: Add support for SDA user and site * Smartadserver Bid Adapter: Fix SDA support getConfig and add to unit testing * support floors per media type * Add GPP support * Rework payloads enriching * Add gpid support --------- Co-authored-by: Meven Courouble <mcourouble@smartadserver.com> Co-authored-by: Krzysztof Sokół <88041828+smart-adserver@users.noreply.github.com> * chore: update default video placement value [PB-1560] (#9948) Co-authored-by: Chris Corbo <chris.corbo@indexexchange.com> * ShareThrough Bid Adapter : fix playerSize (#10011) * fix sharethrough playersize * fix unit test --------- Co-authored-by: Reinout Stevens <reinout@crazygames.com> * GrowthCode RTD : initial release (#9852) * The New RTD Module * GrowthCode new RTD Module * Fixed to Prebid Added Testing Added Docs * Fixed to Prebid Added Testing Added Docs * Completed testing spec * Update the MD file to provide more infomation about what the module does * Update sample to point to the correct server for testing. * Stv Bid Adapter: add schain support (#10010) * initial commit * adapted buildRequests function * refinement pfilter and bcat * refinement * adapted tests for isBidRequestValid,buildRequests * adaptations for test * finished building stvBidAdapter.js * finished: ran tests, coverage 99% * update: rename w->srw, h->srh * adapt stvBidAdapter.md * remove dspx from stv adapters * some changes (missing: getUserSyncs, but is the same as in radsBidAdapter) * added checks in getUserSyncs; ran tests * added schain support (94.8% coverage) * correct schain encoding --------- Co-authored-by: theo_ <theo_@IDEA3> * fix module type (#10019) * Update ad generation adapter 1.6.0: update userSync (#9984) * Update AdGenerationAdapter: update userSync * update test spec * remove onefiftytwo alias --------- Co-authored-by: Krzysztof Sokół <88041828+krzysztofequativ@users.noreply.github.com> Co-authored-by: Meven Courouble <mcourouble@smartadserver.com> Co-authored-by: Krzysztof Sokół <88041828+smart-adserver@users.noreply.github.com> Co-authored-by: ccorbo <ccorbo2013@gmail.com> Co-authored-by: Chris Corbo <chris.corbo@indexexchange.com> Co-authored-by: Reinout Stevens <518971+ReinoutStevens@users.noreply.github.com> Co-authored-by: Reinout Stevens <reinout@crazygames.com> Co-authored-by: southern-growthcode <79725079+southern-growthcode@users.noreply.github.com> Co-authored-by: theo-stv <120092078+theo-stv@users.noreply.github.com> Co-authored-by: theo_ <theo_@IDEA3> Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Co-authored-by: Takaaki.Kojima <banakemi@gmail.com> * Revert "AdTelligent Bid Adapter: remove onefiftytwo alias (#10025)" (#10032) This reverts commit 88dbc04. * Prebid 8: update PBS adapter defaults to signal support for native js trackers (#9900) * Prebid 8: introduce new `transmitTid` activity control (#10034) * Core: introduce new `transmitTid` activity control and turn off TIDs by default * enable TIDs for e2e tests * set session_id param based on the bidderRequestId (#10049) Co-authored-by: Patrick McCann <patmmccann@gmail.com> * appnexus bid adapter - update logic banner adtype in request (#10048) * Prebid 8: do not keep previous floor data on subsequent `setConfig`s (#10051) * Prebid 8: remove NO_BID bids (#9902) * remove NO_BID bids: currency * remove NO_BID bids: priceFloors * remove NO_BID bids: PBS * remove NO_BID status * fix lint * Utiq: Update domain resolving logic and tests (#10044) Co-authored-by: Tomasz Januszek <tomasz@teavaro.com> * Prebid 8: Enforcement, lat and long can only come from the request (#10041) * Update apacdexBidAdapter.js * Update ebdrBidAdapter.js * Update mediafuseBidAdapter.js * Update microadBidAdapter.js * Update zetaBidAdapter.js * Update pubwiseBidAdapter.js * Update pubmaticBidAdapter.js * Update ebdrBidAdapter.js * Update microadBidAdapter.js * Update apacdexBidAdapter.js * Update apacdexBidAdapter_spec.js * Update mediafuseBidAdapter_spec.js * Update pubmaticBidAdapter_spec.js * Update microadBidAdapter_spec.js * Update pubmaticBidAdapter_spec.js * Update pubmaticBidAdapter_spec.js * Prebid 8: remove GDPR check when GDPR enforcement is disabled (#10050) * Cadent Bid Adapter: rename emxdigital to cadent (#10069) * rename files * rename bidder_code * rename adapter object * rename remaining references * add alias from emx_digital --------- Co-authored-by: Michael Denton <mdenton@cadent.tv> * IX Bid Adapter: remove transactionid usage in complience with prebid 8 [PB-1743] (#10070) Co-authored-by: shahin.rahbariasl <shahin.rahbariasl@indexexchange.com> * Update cadentApertureMXBidAdapter.js * Prebid 8: Remove Captify (#10072) * Delete captifyRtdProvider.md * Delete captifyRtdProvider_spec.js * Delete captifyRtdProvider_example.html * Delete captifyRtdProvider.js * Update kargoBidAdapter.js * AdagioBidAdapter: prebid-8: stop using auctionid and transactionid (#10079) * AdagioBidAdapter: stop using Prebid.js internal auctionId and transactionId * AdagioBidAdapter: remove transformBidParams() logic * Criteo Bid Adapter : remove usage of bidRequest.auctionId (#10084) * Grid Bid Adapter : removed embedded criteo bid adapter (#10088) * prebid 8 - read ortb segment data in appnexus keywords library functions (#10082) * prebid8 - read ortb segment data in appnexus keywords library functions * remove null condition from segtax map * airgrid RTD provider: use data segments instead of keywords, remove bidder specific handling (#10080) * Prebid 8: improve `transmitTid` logic for PBS adapter (#10092) * Prebid 8: remove bidder specific handling for 1plusX (#10093) * 1plusX: Do not set keywords for appnexus * weborama: remove appnexus specific handling * remove key=value keyword parsing for appnexus and its clones * fix lint * use 1plusX instead of 1plusx * Revert "remove key=value keyword parsing for appnexus and its clones" This reverts commit 80567cd. * Revert "weborama: remove appnexus specific handling" This reverts commit d6450d1. * 1plusX: add segtax to user data * Update codeql-analysis.yml --------- Co-authored-by: jkthomas <tom.januszek@gmail.com> Co-authored-by: Tomasz Januszek <tomasz@teavaro.com> Co-authored-by: prashuc <105750978+prashuc@users.noreply.github.com> Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> Co-authored-by: Timothy Ace <git.luolix.top-1@timothyace.com> Co-authored-by: Timothy M. Ace <tace@imds.tv> Co-authored-by: Pratik Chavan <pchavan@imds.tv> Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com> Co-authored-by: Robert Ray Martinez III <rrmartinez1552@gmail.com> Co-authored-by: Andrew Slagle <42588549+spotxslagle@users.noreply.github.com> Co-authored-by: Jason Quaccia <jlquaccia@gmail.com> Co-authored-by: olafbuitelaar <olaf.buitelaar@gmail.com> Co-authored-by: Aaron Price <67345931+AaronColbyPrice@users.noreply.github.com> Co-authored-by: aarprice@publicisgroupe.net <aaron.price@epsilon.com> Co-authored-by: Samuel Adu <samuel.adu@gmail.com> Co-authored-by: slimkrazy <sam@slimkrazy.com> Co-authored-by: Gena <wertixvost@gmail.com> Co-authored-by: Krzysztof Sokół <88041828+krzysztofequativ@users.noreply.github.com> Co-authored-by: Meven Courouble <mcourouble@smartadserver.com> Co-authored-by: Krzysztof Sokół <88041828+smart-adserver@users.noreply.github.com> Co-authored-by: ccorbo <ccorbo2013@gmail.com> Co-authored-by: Chris Corbo <chris.corbo@indexexchange.com> Co-authored-by: Reinout Stevens <518971+ReinoutStevens@users.noreply.github.com> Co-authored-by: Reinout Stevens <reinout@crazygames.com> Co-authored-by: southern-growthcode <79725079+southern-growthcode@users.noreply.github.com> Co-authored-by: theo-stv <120092078+theo-stv@users.noreply.github.com> Co-authored-by: theo_ <theo_@IDEA3> Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Co-authored-by: Takaaki.Kojima <banakemi@gmail.com> Co-authored-by: lasloche <62240785+lasloche@users.noreply.github.com> Co-authored-by: EMX Digital <43830380+EMXDigital@users.noreply.github.com> Co-authored-by: Michael Denton <mdenton@cadent.tv> Co-authored-by: shahinrahbariasl <56240400+shahinrahbariasl@users.noreply.github.com> Co-authored-by: shahin.rahbariasl <shahin.rahbariasl@indexexchange.com> Co-authored-by: Olivier <osazos@adagio.io> Co-authored-by: Léonard Labat <le.labat@criteo.com>

* Prebid 8: Delete Inskin (prebid#9868) * Delete inskinBidAdapter.js * Delete inskinBidAdapter.md * Delete inskinBidAdapter_spec.js * Prebid 8: Renaming TrustPid User ID module to Utiq (prebid#9872) * feature: Add trustpid user id module * refactor: Update trustpidSystem module, comments and md file * refactor: Update trustpidSystem file to handle domain setting regardless of message events * refactor: Update trustpidSystem module and dependent tests and docs * refactor: Update trustpid undefined checks and returns * tests: Update trustpid tests * docs: Update trustpid docs typo * refactor: Update trustpid acronyms logic * TrustPid: Remove deprecated acronyms logic * Rename TrustPid User ID module to Utiq --------- Co-authored-by: Tomasz Januszek <tomasz@teavaro.com> * RTB-2173: Removing Inmar from Prebid (prebid#8913) * Delete viewability.js (prebid#9873) * Prebid 8: Delete realvu (prebid#9867) * Delete realvuAnalyticsAdapter_spec.js * Delete realvuAnalyticsAdapter.md * Delete realvuAnalyticsAdapter.js * Prebid 8: Delete pubcid (prebid#9869) * Realvu analytics adapter: fix test failures on Edge (prebid#9857) * Realvu analytics adapter: fix test failures on Edge * Remove realVu tests * Delete pubCommonId.js * Delete pubCommonId.md * Delete pubCommonId_spec.js --------- Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> * Prebid 8: Delete openxortb and analytics (prebid#9864) * Delete openxOrtbBidAdapter.js * Delete openxOrtbBidAdapter.md * Delete openxOrtbBidAdapter_spec.js * Update openxBidAdapter_spec.js * Delete openxAnalyticsAdapter.js * Delete openxAnalyticsAdapter.md * Delete openxAnalyticsAdapter_spec.js * Core & multiple modules: populate ortb2.source.tid (prebid#9862) * Core & multiple modules: populate ortb2.source.tid * enable codeql for prebid-8 * Prebid 8: IMDS bid adapter - Rename synacormedia adapter (prebid#9381) * CAPT-252: Synacormedia bid adapter: add tmax to requests based upon provided timeouts. * Re-brand synacormedia adapter to imds (iMedia Digitial Services) * Add alias to synacormedia for backwards compatibility --------- Co-authored-by: Timothy M. Ace <tace@imds.tv> Co-authored-by: Pratik Chavan <pchavan@imds.tv> * Prebid 8: Dead Module removal (prebid#9887) * Delete liveyieldAnalyticsAdapter_spec.js * Delete liveyieldAnalyticsAdapter.md * Delete liveyieldAnalyticsAdapter.js * Delete glimpseBidAdapter.js * Delete glimpseBidAdapter.md * Delete glimpseBidAdapter_spec.js * Prebid 8: Delete GA analytics - universal analytics (prebid#9866) * Delete googleAnalyticsAdapter.js * Delete googleAnalyticsAdapter.md * Delete googleAnalyticsAdapter_spec.js * Prebid 8: Delete zeus (prebid#9874) * Delete zeusPrimeRtdProvider.md * Delete zeusPrimeRtdProvider.js * Prebid 8: remove special augmentation of `auctionInit` event (prebid#9897) * Prebid 8 - deprecate bidder category translation feature in core (prebid#9898) * prebid 8 - deprecate category translation in core * remove storage export and move mapping data to library file * Prebid 8: Delete adgeneration (prebid#9904) * Delete adgenerationBidAdapter_spec.js * Delete adgenerationBidAdapter.md * Delete adgenerationBidAdapter.js * Prebid 8: do not use hardcoded `bidderCode` in resposes from bid adapters (prebid#9905) * Revert "Prebid 8: Delete adgeneration (prebid#9904)" (prebid#9915) This reverts commit ce984b3. * Prebid 8: No mas mass (prebid#9909) * Delete index.html * Delete mass_spec.js * Delete mass.md * Delete mass.js * Prebid 8: Delete emx (prebid#9918) * Delete emx_digitalBidAdapter.js * Delete emx_digitalBidAdapter.md * Delete emx_digitalBidAdapter_spec.js * Remove Rubicon Analytics for Prebid 8 (prebid#9932) * Prebid 8: stop using transactionId as source.tid on ortb2 payloads (prebid#9916) * Update bizzclickBidAdapter.js * Update rubiconBidAdapter.js * Update gothamadsBidAdapter.js * Update luponmediaBidAdapter.js * Update ozoneBidAdapter.js * Update pubmaticBidAdapter.js * Update improvedigitalBidAdapter.js * Update newspassidBidAdapter.js * Update deltaprojectsBidAdapter.js * Update bizzclickBidAdapter.js * Update deltaprojectsBidAdapter.js * Update gothamadsBidAdapter.js * Update luponmediaBidAdapter.js * Update newspassidBidAdapter.js * Update ozoneBidAdapter.js * Update pubmaticBidAdapter.js * Update rubiconBidAdapter.js * Update improvedigitalBidAdapter_spec.js * Update luponmediaBidAdapter_spec.js * Update rubiconBidAdapter_spec.js * Update improvedigitalBidAdapter.js * Update pubmaticBidAdapter.js * Update improvedigitalBidAdapter.js * Update pubmaticBidAdapter.js * Update pubmaticBidAdapter.js * Update pubmaticBidAdapter_spec.js * Update adtrueBidAdapter.js * Update adtrueBidAdapter_spec.js * Update adtrueBidAdapter.js * Update adtrueBidAdapter_spec.js * Update adtrueBidAdapter_spec.js * Do not call onBidViewable, onBidWon, etc for S2S bids (prebid#9919) * Access x_source.tid from ortb2 object (prebid#9960) * Access x_source.tid from ortb2 object * Fix lint errors * Prebid 8: set pubmatic source.tid to auctionId (prebid#9954) * set source.tid to auctionId * removed changes to test page * added support for setting ext.wrapper.transactionId as well * Prebid 8: use `prebid.floors.floorMin` instead of `prebid.floorMin` (prebid#9899) * Prebid 8: remove shutdown company from appnexus aliases (prebid#9977) * Update appnexusBidAdapter.js * Update appnexusBidAdapter.js * add bidResponse before emitting the event BID_RESPONSE, so that the bid is stored in the auction instance when the event is triggered (prebid#9847) * Multiple modules: use `ortb2.source.tid` and `ortb2Imp.ext.tid` instead of auctionId/transactionId (prebid#9969) * adkernel * aidem * beop * bliink * criteo * feedad * grid * kargo * medianet * optidigital * rubicon * smilewanted * Multiple modules: use `ortb2.source.tid` and `ortb2Imp.ext.tid` instead of auction/transaction IDs * tappx * onetag * use bidderRequestId instead of generateUUID * Epsilon - Prebid v8 changes to remove documentation in coding project (prebid#9966) Co-authored-by: aarprice@publicisgroupe.net <aaron.price@epsilon.com> * Prebid 8: pick keywords from FPD in addition to bid params (prebid#9917) * extract appnexus-style keyword logic into its own library * refactor appnexus clones to share keyword logic * pick keywords from ortb2 in addition to bid params * Prebid 8: support sizeMapping for video; extract it into a module (prebid#9893) * Core: support sizeMapping for video * make sizeMapping a module * Magnite Analytics Adapter : do not rely on BID_RESPONSE 0cpm rejected bids (prebid#9933) * Magnite Analytics - Do not rely on BID_RESPONSE for rejected bids * use rejection floor constant! * Remove AOL bid adapter (prebid#10030) Co-authored-by: slimkrazy <sam@slimkrazy.com> * AdTelligent Bid Adapter: remove onefiftytwo alias (prebid#10025) * Smartadserver Bid Adapter: support GPID (prebid#10004) * Smartadserver Bid Adapter: Add support for SDA user and site * Smartadserver Bid Adapter: Fix SDA support getConfig and add to unit testing * support floors per media type * Add GPP support * Rework payloads enriching * Add gpid support --------- Co-authored-by: Meven Courouble <mcourouble@smartadserver.com> Co-authored-by: Krzysztof Sokół <88041828+smart-adserver@users.noreply.github.com> * chore: update default video placement value [PB-1560] (prebid#9948) Co-authored-by: Chris Corbo <chris.corbo@indexexchange.com> * ShareThrough Bid Adapter : fix playerSize (prebid#10011) * fix sharethrough playersize * fix unit test --------- Co-authored-by: Reinout Stevens <reinout@crazygames.com> * GrowthCode RTD : initial release (prebid#9852) * The New RTD Module * GrowthCode new RTD Module * Fixed to Prebid Added Testing Added Docs * Fixed to Prebid Added Testing Added Docs * Completed testing spec * Update the MD file to provide more infomation about what the module does * Update sample to point to the correct server for testing. * Stv Bid Adapter: add schain support (prebid#10010) * initial commit * adapted buildRequests function * refinement pfilter and bcat * refinement * adapted tests for isBidRequestValid,buildRequests * adaptations for test * finished building stvBidAdapter.js * finished: ran tests, coverage 99% * update: rename w->srw, h->srh * adapt stvBidAdapter.md * remove dspx from stv adapters * some changes (missing: getUserSyncs, but is the same as in radsBidAdapter) * added checks in getUserSyncs; ran tests * added schain support (94.8% coverage) * correct schain encoding --------- Co-authored-by: theo_ <theo_@IDEA3> * fix module type (prebid#10019) * Update ad generation adapter 1.6.0: update userSync (prebid#9984) * Update AdGenerationAdapter: update userSync * update test spec * remove onefiftytwo alias --------- Co-authored-by: Krzysztof Sokół <88041828+krzysztofequativ@users.noreply.github.com> Co-authored-by: Meven Courouble <mcourouble@smartadserver.com> Co-authored-by: Krzysztof Sokół <88041828+smart-adserver@users.noreply.github.com> Co-authored-by: ccorbo <ccorbo2013@gmail.com> Co-authored-by: Chris Corbo <chris.corbo@indexexchange.com> Co-authored-by: Reinout Stevens <518971+ReinoutStevens@users.noreply.github.com> Co-authored-by: Reinout Stevens <reinout@crazygames.com> Co-authored-by: southern-growthcode <79725079+southern-growthcode@users.noreply.github.com> Co-authored-by: theo-stv <120092078+theo-stv@users.noreply.github.com> Co-authored-by: theo_ <theo_@IDEA3> Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Co-authored-by: Takaaki.Kojima <banakemi@gmail.com> * Revert "AdTelligent Bid Adapter: remove onefiftytwo alias (prebid#10025)" (prebid#10032) This reverts commit 88dbc04. * Prebid 8: update PBS adapter defaults to signal support for native js trackers (prebid#9900) * Prebid 8: introduce new `transmitTid` activity control (prebid#10034) * Core: introduce new `transmitTid` activity control and turn off TIDs by default * enable TIDs for e2e tests * set session_id param based on the bidderRequestId (prebid#10049) Co-authored-by: Patrick McCann <patmmccann@gmail.com> * appnexus bid adapter - update logic banner adtype in request (prebid#10048) * Prebid 8: do not keep previous floor data on subsequent `setConfig`s (prebid#10051) * Prebid 8: remove NO_BID bids (prebid#9902) * remove NO_BID bids: currency * remove NO_BID bids: priceFloors * remove NO_BID bids: PBS * remove NO_BID status * fix lint * Utiq: Update domain resolving logic and tests (prebid#10044) Co-authored-by: Tomasz Januszek <tomasz@teavaro.com> * Prebid 8: Enforcement, lat and long can only come from the request (prebid#10041) * Update apacdexBidAdapter.js * Update ebdrBidAdapter.js * Update mediafuseBidAdapter.js * Update microadBidAdapter.js * Update zetaBidAdapter.js * Update pubwiseBidAdapter.js * Update pubmaticBidAdapter.js * Update ebdrBidAdapter.js * Update microadBidAdapter.js * Update apacdexBidAdapter.js * Update apacdexBidAdapter_spec.js * Update mediafuseBidAdapter_spec.js * Update pubmaticBidAdapter_spec.js * Update microadBidAdapter_spec.js * Update pubmaticBidAdapter_spec.js * Update pubmaticBidAdapter_spec.js * Prebid 8: remove GDPR check when GDPR enforcement is disabled (prebid#10050) * Cadent Bid Adapter: rename emxdigital to cadent (prebid#10069) * rename files * rename bidder_code * rename adapter object * rename remaining references * add alias from emx_digital --------- Co-authored-by: Michael Denton <mdenton@cadent.tv> * IX Bid Adapter: remove transactionid usage in complience with prebid 8 [PB-1743] (prebid#10070) Co-authored-by: shahin.rahbariasl <shahin.rahbariasl@indexexchange.com> * Update cadentApertureMXBidAdapter.js * Prebid 8: Remove Captify (prebid#10072) * Delete captifyRtdProvider.md * Delete captifyRtdProvider_spec.js * Delete captifyRtdProvider_example.html * Delete captifyRtdProvider.js * Update kargoBidAdapter.js * AdagioBidAdapter: prebid-8: stop using auctionid and transactionid (prebid#10079) * AdagioBidAdapter: stop using Prebid.js internal auctionId and transactionId * AdagioBidAdapter: remove transformBidParams() logic * Criteo Bid Adapter : remove usage of bidRequest.auctionId (prebid#10084) * Grid Bid Adapter : removed embedded criteo bid adapter (prebid#10088) * prebid 8 - read ortb segment data in appnexus keywords library functions (prebid#10082) * prebid8 - read ortb segment data in appnexus keywords library functions * remove null condition from segtax map * airgrid RTD provider: use data segments instead of keywords, remove bidder specific handling (prebid#10080) * Prebid 8: improve `transmitTid` logic for PBS adapter (prebid#10092) * Prebid 8: remove bidder specific handling for 1plusX (prebid#10093) * 1plusX: Do not set keywords for appnexus * weborama: remove appnexus specific handling * remove key=value keyword parsing for appnexus and its clones * fix lint * use 1plusX instead of 1plusx * Revert "remove key=value keyword parsing for appnexus and its clones" This reverts commit 80567cd. * Revert "weborama: remove appnexus specific handling" This reverts commit d6450d1. * 1plusX: add segtax to user data * Update codeql-analysis.yml --------- Co-authored-by: jkthomas <tom.januszek@gmail.com> Co-authored-by: Tomasz Januszek <tomasz@teavaro.com> Co-authored-by: prashuc <105750978+prashuc@users.noreply.github.com> Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> Co-authored-by: Timothy Ace <git.luolix.top-1@timothyace.com> Co-authored-by: Timothy M. Ace <tace@imds.tv> Co-authored-by: Pratik Chavan <pchavan@imds.tv> Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com> Co-authored-by: Robert Ray Martinez III <rrmartinez1552@gmail.com> Co-authored-by: Andrew Slagle <42588549+spotxslagle@users.noreply.github.com> Co-authored-by: Jason Quaccia <jlquaccia@gmail.com> Co-authored-by: olafbuitelaar <olaf.buitelaar@gmail.com> Co-authored-by: Aaron Price <67345931+AaronColbyPrice@users.noreply.github.com> Co-authored-by: aarprice@publicisgroupe.net <aaron.price@epsilon.com> Co-authored-by: Samuel Adu <samuel.adu@gmail.com> Co-authored-by: slimkrazy <sam@slimkrazy.com> Co-authored-by: Gena <wertixvost@gmail.com> Co-authored-by: Krzysztof Sokół <88041828+krzysztofequativ@users.noreply.github.com> Co-authored-by: Meven Courouble <mcourouble@smartadserver.com> Co-authored-by: Krzysztof Sokół <88041828+smart-adserver@users.noreply.github.com> Co-authored-by: ccorbo <ccorbo2013@gmail.com> Co-authored-by: Chris Corbo <chris.corbo@indexexchange.com> Co-authored-by: Reinout Stevens <518971+ReinoutStevens@users.noreply.github.com> Co-authored-by: Reinout Stevens <reinout@crazygames.com> Co-authored-by: southern-growthcode <79725079+southern-growthcode@users.noreply.github.com> Co-authored-by: theo-stv <120092078+theo-stv@users.noreply.github.com> Co-authored-by: theo_ <theo_@IDEA3> Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Co-authored-by: Takaaki.Kojima <banakemi@gmail.com> Co-authored-by: lasloche <62240785+lasloche@users.noreply.github.com> Co-authored-by: EMX Digital <43830380+EMXDigital@users.noreply.github.com> Co-authored-by: Michael Denton <mdenton@cadent.tv> Co-authored-by: shahinrahbariasl <56240400+shahinrahbariasl@users.noreply.github.com> Co-authored-by: shahin.rahbariasl <shahin.rahbariasl@indexexchange.com> Co-authored-by: Olivier <osazos@adagio.io> Co-authored-by: Léonard Labat <le.labat@criteo.com>

dgirardi added 14 commits May 9, 2023 10:13

adkernel

fa7aa7e

aidem

ecd369f

beop

db9f278

bliink

bd3f282

criteo

05121d9

feedad

55ee0cf

grid

79fe71f

kargo

6b81767

medianet

0719cb1

optidigital

e148e32

rubicon

d746cda

smilewanted

42b5bf4

Multiple modules: use ortb2.source.tid and ortb2Imp.ext.tid inste…

6ed3a3c

…ad of auction/transaction IDs

Merge branch 'prebid-8' into source-tid

5fd00e1

dgirardi force-pushed the source-tid branch from b59415d to 5fd00e1 Compare May 18, 2023 16:45

ChrisHuie added 8.0 API Change feature labels May 18, 2023

ChrisHuie self-requested a review May 18, 2023 18:27

ChrisHuie self-assigned this May 18, 2023