Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimizes new allocations inside the request signature. Consider this a work in progress... I'm just chipping away at it whenever I find myself waiting for someone.
This was based on Sweeney's advice that we use
sync.Pool
to ease garbage collector pressure. The primary goal is minimizing allocations per request... but that usually corresponds to faster speed improvements too.Benchmark before changes:
Number of mallocs: 30
Benchmark after changes:
Number of mallocs: 19