Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move js assets for mraid and omid to jsdelivr.com #634

Closed
YuriyVelichkoPI opened this issue Jun 1, 2023 · 0 comments · Fixed by #643
Closed

Move js assets for mraid and omid to jsdelivr.com #634

YuriyVelichkoPI opened this issue Jun 1, 2023 · 0 comments · Fixed by #643
Assignees
@ValentinPostindustria
Milestone
2.1.1

Comments

@YuriyVelichkoPI
Copy link
Contributor

Objective

  • host files omsdk.js and mraid.js on jsdelivr.com.
  • download these files on sdk initialization and use them eventually on rendering.

You can follow instructions from this comment to implement the download/utilization flow in the same way as on iOS.
@YuriyVelichkoPI YuriyVelichkoPI added this to the 2.1.1 milestone Jun 1, 2023
ValentinPostindustria added a commit that referenced this issue Jun 13, 2023
@ValentinPostindustria
feat: move js files #634
e0ce2ae
Merged
YuriyVelichkoPI pushed a commit that referenced this issue Jun 13, 2023
@ValentinPostindustria
Move js files #634 (#641)
3422f2e
ValentinPostindustria added a commit that referenced this issue Jun 14, 2023
@ValentinPostindustria
feat: js scripts downloading functionality #634
19d0f6b
ValentinPostindustria added a commit that referenced this issue Jun 14, 2023
@ValentinPostindustria
feat: update js script usages and JSLibraryManager #634
742b2af
ValentinPostindustria added a commit that referenced this issue Jun 14, 2023
@ValentinPostindustria
feat: update url #634
29a1eaa
ValentinPostindustria added a commit that referenced this issue Jun 14, 2023
@ValentinPostindustria
feat: fix removing after downloading #634
18d31fb
ValentinPostindustria added a commit that referenced this issue Jun 14, 2023
@ValentinPostindustria
feat: remove scripts from other folders #634
8fc0db9
ValentinPostindustria added a commit that referenced this issue Jun 14, 2023
@ValentinPostindustria
feat: some corrections #634
e1e33aa
ValentinPostindustria added a commit that referenced this issue Jun 14, 2023
@ValentinPostindustria
test: unit tests #634
0d8cd15
Merged
ValentinPostindustria added a commit that referenced this issue Jun 15, 2023
@ValentinPostindustria
fix: reading js scripts with line breaks #634
c903692
YuriyVelichkoPI pushed a commit that referenced this issue Jun 15, 2023
@ValentinPostindustria
Remote js scripts (#643)
10d0386 
* feat: js scripts downloading functionality #634

* feat: update js script usages and JSLibraryManager #634

* feat: update url #634

* feat: fix removing after downloading #634

* feat: remove scripts from other folders #634

* feat: some corrections #634

* test: unit tests #634

* fix: reading js scripts with line breaks  #634
ValentinPostindustria added a commit that referenced this issue Jun 15, 2023
@ValentinPostindustria
fix: reading js scripts with line breaks #634
0a81ab7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ValentinPostindustria ValentinPostindustria

Labels
None yet
Projects
Prebid Mobile Prioritization
Status: Done
Milestone
2.1.1
Development

Successfully merging a pull request may close this issue.

Remote js scripts prebid/prebid-mobile-android
2 participants
@YuriyVelichkoPI @ValentinPostindustria