Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setInv function #95

Closed
wants to merge 3 commits into from
Closed

setInv function #95

wants to merge 3 commits into from

Conversation

AntoineJac
Copy link
Contributor

Regarding to issue:
prebid/prebid-mobile-ios#165

This is the android PR for the function.

Copy link
Collaborator

@ppuviarasu ppuviarasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The setting on user keywords needs to be done per adUnit. This was the cautious decision made when we redesigned Prebid. prebid/prebid-mobile-ios#113
Lets keep the same

Copy link
Contributor

@anwzhang anwzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See Punnaghai's comment

@anwzhang anwzhang dismissed their stale review March 26, 2019 14:51

Discussed offline.

@AntoineJac
Copy link
Contributor Author

AntoineJac commented Mar 27, 2019

Thanks all, let stall this until prebid/prebid-mobile-ios#165 has been validated and an intent to implement decided.

@AntoineJac
Copy link
Contributor Author

Will use the new pass data api

@AntoineJac AntoineJac closed this May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants