Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring/Improvement #230

Merged
merged 12 commits into from
Aug 29, 2019
Merged

Refactoring/Improvement #230

merged 12 commits into from
Aug 29, 2019

Conversation

yoalex5
Copy link
Collaborator

@yoalex5 yoalex5 commented Aug 7, 2019

These changes generally refactor the FirstPartyData PR. Plus minor changes

  1. AdUnit.UserKeyword uses TargetingParams.UserKeyword inside. The parameter key will be omitted
  2. a code that is related to FPD was improved and refactored
  3. tests were improved

@yoalex5 yoalex5 requested a review from ppuviarasu August 7, 2019 18:23
@yoalex5 yoalex5 added this to the Prebid SDK 1.2 milestone Aug 7, 2019
@yoalex5 yoalex5 changed the title Minor refactoring Refactoring/Improvement Aug 8, 2019
@anwzhang
Copy link
Contributor

Hi @yoalex5, can you resolve the merge conflict on this branch?

*/
@available(*, deprecated, message: "Please use Targeting.shared.addUserKeyword() method instead")
@available(*, deprecated, message: "Please use Targeting.addUserKeyword() method instead")
public func addUserKeyword(key: String, value: String) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if key is omitted, why not change the API to be just passing one String, same as Android?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, the new targeting keywords should not utilize a key. It should be a static string. I believe this may be a mistake.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @anwzhang,

if key is omitted, why not change the API to be just passing one String

I did not do it because it is a public API and I want to have a backward compatibility

same as Android

Android version has the same changes
https://github.com/prebid/prebid-mobile-android/blob/67df7e2f9be348f33147681454a1e94f66ec1a97/PrebidMobile/API1.0/src/main/java/org/prebid/mobile/AdUnit.java#L150

If you wish I can change PRs for iOS and Android what will entail breaking changes as a result we have to change a major version

# Conflicts:
#	src/PrebidMobile/PrebidMobile/RequestBuilder.swift
#	src/PrebidMobile/PrebidMobileTests/FetchingLogictests/RequestBuilderTests.swift
@yoalex5
Copy link
Collaborator Author

yoalex5 commented Aug 27, 2019

@anwzhang, I have resolved the merge conflicts

@yoalex5
Copy link
Collaborator Author

yoalex5 commented Aug 28, 2019

@anwzhang, could you please review it ?

@yoalex5 yoalex5 merged commit 718640f into prebid:master Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants