-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for US Privacy flag #256
Conversation
2. fixed gdpr exception prebid#243 3. subjectToGDPR can be assign to nil to get an iab value 4. refactoring 5. tests were added
|
||
import Foundation | ||
|
||
class StorageUtils { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we call this PrivacyUtils?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
StorageUtils
is a general utility class to work with persistent storage. It will allow us to expand this class in future without generating a lot of small classes. If we had several big logic entities I would create PrivacyUtils
, StorageUtils
etc.
Please keep it as is and we will change it when it will be necessary
} | ||
|
||
ext["us_privacy"] = StorageUtils.iabCcpa() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this object ext["us_privacy"]
created even if the ccpa is empty or nil?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If StorageUtils.iabCcpa()
returns nil
or empty string the ext["us_privacy"]
will not be created
Check tests: testPostDataWithEmptyCCPA
and testPostDataWithoutCCPA
API:
OpenRTB request:
subjectToGDPR
can be assign tonil
to get an IAB value