Fix Dispatcher leak #849
Merged
Fix Dispatcher leak #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -74,6 +74,10 @@ public class AdUnit: NSObject, DispatcherDelegate { | |||
| // PBS should cache the bid for original api. | |||
| Prebid.shared.useCacheForReportingWithRenderingAPI = true | |||
| } | |||
|
|
|||
| deinit { | |||
| dispatcher?.invalidate() | |||
There was a problem hiding this comment.
Can we invalidate / stop dispatcher in the deinit of Dispatcher itself?
There was a problem hiding this comment.
Unfortunately, we can't cause Timer holds a strong reference to Dispatcher, which means deinit is never called until Timer gets invalidated.
There was a problem hiding this comment.
I see. Thanks for the explanation.
YuriyVelichkoPI
approved these changes
May 19, 2023
| @@ -74,6 +74,10 @@ public class AdUnit: NSObject, DispatcherDelegate { | |||
| // PBS should cache the bid for original api. | |||
| Prebid.shared.useCacheForReportingWithRenderingAPI = true | |||
| } | |||
|
|
|||
| deinit { | |||
| dispatcher?.invalidate() | |||
There was a problem hiding this comment.
I see. Thanks for the explanation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#840