Fix MAX base adapter initialization #863
Conversation
| @@ -42,7 +42,6 @@ public class PrebidMAXMediationAdapter: ALMediationAdapter { | |||
| public weak var nativeDelegate: MANativeAdAdapterDelegate? | |||
|
|
|||
| public override func initialize(with parameters: MAAdapterInitializationParameters, completionHandler: @escaping (MAAdapterInitializationStatus, String?) -> Void) { | |||
| super.initialize(with: parameters, completionHandler: completionHandler) | |||
| Targeting.shared.subjectToCOPPA = ALPrivacySettings.isAgeRestrictedUser() | |||
There was a problem hiding this comment.
I am not very familiar with AppLovins custom Mediation Adapters, but maybe it's worth calling the completionHandler.
Here in point 2 - they list appropriate statuses: https://support.applovin.com/hc/en-us/articles/11593969055245-Building-a-Custom-Adapter
There was a problem hiding this comment.
Hi @kubamatula ! Agree, it make sense to signal about initialization completion once all needed steps are done.
Also, I would like to note that we will review the Prebid SDK initialization flow in case of integration via AdMob/MAX adapters in a way recommended in the development guides. To follow the adapters' implementation best practices, the Prebid SDK should be initialized inside the adapter. But such changes may require deeper analysis to avoid issues with possible repetitive initializations.
So in this task's scope, we will introduce the fix, and the flow improvement will be performed eventually.
#862