Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add userr id to bid request #880

Merged
merged 4 commits into from
Aug 4, 2023
Merged

add userr id to bid request #880

merged 4 commits into from
Aug 4, 2023

Conversation

huanzhiNB
Copy link
Contributor

No description provided.

@huanzhiNB huanzhiNB mentioned this pull request Jul 18, 2023
Closed
@huanzhiNB
Copy link
Contributor Author

added unit test, also changed comment text

@huanzhiNB
Copy link
Contributor Author

Resolved. Please take a look @YuriyVelichkoPI @OlenaPostindustria . By the way, what's the common practice to contribute back? Currently this PR is created on my personal fork, and I don't have access to main repo.

@YuriyVelichkoPI
Copy link
Contributor

YuriyVelichkoPI commented Jul 31, 2023 •
edited

Hi @huanzhiNB ! Yes, it's an expected way to contribute to all prebid repositories.

We plan to make a release soon. So it will be great if you finalize the PR by fixing the tests and we merge the changes.

@YuriyVelichkoPI
Copy link
Contributor

Hi @huanzhiNB ! Any updates about finalization?

@YuriyVelichkoPI
Copy link
Contributor

closes #881

@huanzhiNB
Copy link
Contributor Author

@YuriyVelichkoPI @OlenaPostindustria Sry, had other projects going on and nearly forgot about this. I just changed the unit test case as suggested.

@huanzhiNB
Copy link
Contributor Author

update expected string, tested myself. This time it should be good @OlenaPostindustria

OlenaPostindustria
OlenaPostindustria approved these changes Aug 4, 2023
View reviewed changes
Copy link
Collaborator

@OlenaPostindustria OlenaPostindustria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OlenaPostindustria OlenaPostindustria linked an issue Aug 4, 2023 that may be closed by this pull request
Missing user id in ad request in iOS SDK #881
Closed
YuriyVelichkoPI
YuriyVelichkoPI approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@YuriyVelichkoPI YuriyVelichkoPI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuriyVelichkoPI YuriyVelichkoPI merged commit 2e9c1ed into prebid:master Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriyVelichkoPI YuriyVelichkoPI YuriyVelichkoPI approved these changes

@OlenaPostindustria OlenaPostindustria OlenaPostindustria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing user id in ad request in iOS SDK
3 participants
@huanzhiNB @YuriyVelichkoPI @OlenaPostindustria