Change default omidpv value to Prebid SDK version in rendering API #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jsligh, the changes look good. However, the tests failed, could you check the reason and fix? From time to time some steps failed and we just restart them. I've tried to restart one without success still see an error. Will try one more time. |
|
@YuriyVelichkoPI I ran the failing test 10 times in a row on my branch and they all passed. I'm running circleCI again. |
|
@OlenaPostindustria could you take a look at the failed pipeline? |
|
@jsligh, please rebase the branch to get the tests passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed to use Prebid SDK Version (like it does on Android). Removed the omidversion function as it was a hardcoded value and no longer needed as the Prebid SDK version is always used. Also updated the tests to use the SDK version and ran all tests and they passed.
Addresses this issue: #884