-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support GMA SDK 10.8.0 #887
Conversation
@@ -183,16 +180,27 @@ public class Prebid: NSObject { | |||
/// - Parameters: | |||
/// - gadMobileAdsObject: GADMobileAds object | |||
/// - completion: returns initialization status and optional error | |||
@available(*, deprecated, message: "If the GMA SDK version is higher than 10.7.0 you should use `initializeSDK(gadMobileAdsVersion:, _ completion:)` method in order to initialize Prebid SDK.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't deprecate this method so far because publishers still can use previous GMA SDK versions, and we shouldn't push them to migrate (via warning).
We should log the message in the checkGMAVersion
method if the publisher updated the GMA SDK but still use this initializer.
cc: @jsligh This PR is intended to fix UI tests. |
…ogic to separate class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #886
Prebid.initializeSDK(gadMobileAdsVersion: String? = nil, _ completion: PrebidInitializationCallback? = nil)