Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SKAdN sourceIdentifier availability check #890

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Fix SKAdN sourceIdentifier availability check #890

merged 1 commit into from
Aug 1, 2023

Conversation

OlenaPostindustria
Copy link
Collaborator

@OlenaPostindustria OlenaPostindustria marked this pull request as ready for review August 1, 2023 07:21
YuriyVelichkoPI
YuriyVelichkoPI approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@YuriyVelichkoPI YuriyVelichkoPI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

But just want to mention that building with Xcode 14.* does not leads to this error because:

image

@YuriyVelichkoPI YuriyVelichkoPI merged commit cc822df into master Aug 1, 2023
4 checks passed
@OlenaPostindustria OlenaPostindustria deleted the fix/skadn-availability branch August 1, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriyVelichkoPI YuriyVelichkoPI YuriyVelichkoPI approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OlenaPostindustria @YuriyVelichkoPI