Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement multiformat ad unit for Original API #914

Merged
merged 20 commits into from
Sep 28, 2023
Merged

Implement multiformat ad unit for Original API #914

merged 20 commits into from
Sep 28, 2023

Conversation

OlenaPostindustria
Copy link
Collaborator

@OlenaPostindustria OlenaPostindustria commented Sep 21, 2023 •
edited

Closes #913
Closes #912

@OlenaPostindustria OlenaPostindustria marked this pull request as ready for review September 22, 2023 08:06
@OlenaPostindustria
feat: implement multiformat ad unit
1a37cd1
@OlenaPostindustria
feat: add SDK unit tests
a6b9b3a
@OlenaPostindustria
feat: add examples to demo apps
792bd08
@OlenaPostindustria
feat: add smoke ui test for multiformat case
f4de4a4
@OlenaPostindustria
feat: implement dynamic multiformat example in InternalTestApp
d55a182
@OlenaPostindustria
feat: remove unneeded setSizes from BannerParameters
5b5eacb
@OlenaPostindustria
refactor: rename processFetchDemand to baseFetchDemand & refactor whi…
321aaa2 
…tespaces check
@OlenaPostindustria
feat: move new fetchDemand methods to PrebidAdUnit
006e52e
@OlenaPostindustria
refactor: enhance baseFetchDemand
09125f1
@OlenaPostindustria
refactor: enhance base fetch demand
2daf7f9
@OlenaPostindustria
feat: add unit tests
9b62501
@OlenaPostindustria
feat: clean
65dfe09
@OlenaPostindustria
feat: make dispatcher and adUnitConfig get-only
200167d
@OlenaPostindustria
fix: fix testFetchDemandBids test
bd27477
@OlenaPostindustria
feat: update test case title to fix test
594b4fe
@OlenaPostindustria
feat: add fetchDemand with BidInfo to AdUnit & deprecate fetchDemand …
6e9e457 
…with kvResultDict & add tests
@OlenaPostindustria
feat: add multiformat with native styles test case to InternalTestApp
8478afb
@OlenaPostindustria
feat: add multiformat with native styles test case to Demo Apps
16ab603
@YuriyVelichkoPI YuriyVelichkoPI mentioned this pull request Sep 26, 2023
Merged
7 tasks
jsligh
jsligh approved these changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@jsligh jsligh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

YuriyVelichkoPI
YuriyVelichkoPI approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@YuriyVelichkoPI YuriyVelichkoPI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsligh jsligh merged commit 072a004 into master Sep 28, 2023
4 checks passed
@jsligh jsligh deleted the feature/multiformat-adunit branch September 28, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriyVelichkoPI YuriyVelichkoPI YuriyVelichkoPI approved these changes

@jsligh jsligh jsligh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiformat ad unit for Original API Provide more bid info in the fetchDemand completion handler
3 participants
@OlenaPostindustria @YuriyVelichkoPI @jsligh