Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support impression-level GPID parameter #928

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Support impression-level GPID parameter #928

merged 3 commits into from
Oct 12, 2023

Conversation

OlenaPostindustria
Copy link
Collaborator

Closes #925

YuriyVelichkoPI
YuriyVelichkoPI approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@YuriyVelichkoPI YuriyVelichkoPI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jsligh
jsligh approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@jsligh jsligh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jsligh jsligh merged commit 8debeb4 into master Oct 12, 2023
4 checks passed
@jsligh jsligh deleted the 925/gpid-parameter branch October 12, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriyVelichkoPI YuriyVelichkoPI YuriyVelichkoPI approved these changes

@jsligh jsligh jsligh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support impression-level GPID parameter
3 participants
@OlenaPostindustria @YuriyVelichkoPI @jsligh