Remove data from request as its already contained on the uploadTask #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@OlenaPostindustria, @YuriyVelichkoPI can I get some 👀 on this? 🙏 |
|
@aiFigueiredo Apologies, I'm just now seeing this. I believe this should fix the issue and should not affect the uploadTask negatively as you previously stated because the body is already part of the upload task. |
|
Thanks @jsligh, what do we need to get this merged in and on a new release? I assume this will affect all clients that use this SDK and support the latest iOS version |
|
@aiFigueiredo I am merging this and hope to get a new build out next week sometime once a couple more PR's have been reviewed and merged. |
|
Thanks @jsligh, appreciate the 👀 and the info. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to address issue #920 where an error is shown on
session.uploadTaskwhen the request contains a body.As the title states, the data should not be required in the request as its already passed to the
uploadTaskmethod.