Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix device UA being empty on first bid request without blocking application #983

Merged
merged 2 commits into from
May 22, 2024
Merged

Fix device UA being empty on first bid request without blocking application #983

merged 2 commits into from
May 22, 2024

Conversation

OlenaPostindustria
Copy link
Collaborator

@OlenaPostindustria OlenaPostindustria marked this pull request as ready for review May 21, 2024 10:39
YuriyVelichkoPI
YuriyVelichkoPI requested changes May 21, 2024
View reviewed changes
Copy link
Contributor

@YuriyVelichkoPI YuriyVelichkoPI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also measure the average, minimum, and maximum time for extracting the user agent string, as well as the number of errors per 1 million attempts from different web view instances?

The current solution does not have a timeout option, so we need to ensure that the value will be fetched reliably.

PrebidMobile/PrebidMobileRendering/Prebid/PBMCore/PBMBidRequester.m Outdated Show resolved Hide resolved
PrebidMobile/PrebidMobileRendering/Utilities/UserAgentService.swift Outdated Show resolved Hide resolved
@OlenaPostindustria
Copy link
Collaborator Author

Could you also measure the average, minimum, and maximum time for extracting the user agent string, as well as the number of errors per 1 million attempts from different web view instances?

The current solution does not have a timeout option, so we need to ensure that the value will be fetched reliably.

min - 0.0004010200500488281 s
max - 0.521765947341919 s
average - 0.0019949429631233215 s
number of errors per 1 million attempts - 2

YuriyVelichkoPI
YuriyVelichkoPI approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@YuriyVelichkoPI YuriyVelichkoPI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuriyVelichkoPI YuriyVelichkoPI mentioned this pull request May 21, 2024
Closed
@jsligh
Copy link
Collaborator

jsligh commented May 22, 2024

@OlenaPostindustria Thank you so much for tackling this bug! I have merged the PR for fixing the tests so you should be able to rebase and then the tests should pass!

@jsligh jsligh mentioned this pull request May 22, 2024
Closed
@jsligh
Copy link
Collaborator

jsligh commented May 22, 2024

LGTM

@jsligh jsligh merged commit 8ee1a28 into master May 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriyVelichkoPI YuriyVelichkoPI YuriyVelichkoPI approved these changes

@jsligh jsligh jsligh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@OlenaPostindustria @jsligh @YuriyVelichkoPI