Fixed: App Crash on Ad Redirect to Unsupported URL Scheme #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weibel
changed the title
weibel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During click handling, an attempt to open SFSafariViewController could result in a crash with the error:
This PR addresses the issue by adding a check for the URL scheme in the PBMSafariVCOpener class to ensure it only attempts to open URLs with "http" or "https" schemes. If the URL has an unsupported scheme, the SDK will now log an error message and prevent SFSafariViewController from opening the unsupported URL, thereby preventing the app from crashing.
Background
This issue occurs when an ad redirects to "about" or when a user quickly clicks on an ad as soon as it appears, causing the app to crash due to an uncaught NSInvalidArgumentException. The fix ensures the app handles unsupported URL schemes gracefully.
Changes
Added a check for the URL scheme in the PBMSafariVCOpener class.
If the URL scheme is not "http" or "https", log an error message and do not attempt to open the URL in SFSafariViewController.
Fixes #966