Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Issue 981 #991

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Fixes for Issue 981 #991

merged 2 commits into from
Jun 3, 2024

Conversation

ankit-thanekar007
Copy link
Contributor

@ankit-thanekar007 ankit-thanekar007 commented May 30, 2024

Related Issue #981

  • Add NS_SWIFT_NAME to remove deprecated method warning.
  • Make changes for the same in MockUIApplication.swift

@ankit-thanekar007
Copy link
Contributor Author

Hi @jsligh @YuriyVelichkoPI, Is it possible to get this PR reviewed, merged & released in a patch release ?

@jsligh
Copy link
Collaborator

jsligh commented May 31, 2024

@ankit-thanekar007 We prefer to remove deprecated methods in major releases and the next will be 3.0 which will be released later this year.

@ankit-thanekar007
Copy link
Contributor Author

ankit-thanekar007 commented May 31, 2024

@jsligh I can add NS_SWIFT_NAME property here that can also fix the issue for a patch release and not remove any deprecated methods. Will that be okay?

- (BOOL)openURL:(nonnull NSURL*)url NS_SWIFT_NAME(openURL(url:)) NS_DEPRECATED_IOS(2_0, 10_0, "Please use openURL:options:completionHandler: instead") NS_EXTENSION_UNAVAILABLE_IOS("");

Would require 1 change in MockUIApplication.swift

@jsligh
Copy link
Collaborator

jsligh commented May 31, 2024

@ankit-thanekar007 that sounds like a good compromise. Please make the changes so I can test them.

@ankit-thanekar007
Copy link
Contributor Author

@jsligh Pushed the changes

@jsligh jsligh self-requested a review June 3, 2024 15:59
Copy link
Collaborator

@jsligh jsligh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jsligh jsligh merged commit 66db238 into prebid:master Jun 3, 2024
@ankit-thanekar007
Copy link
Contributor Author

Thanks @jsligh for merging. Is there a date for patch release ?

@jsligh
Copy link
Collaborator

jsligh commented Jun 3, 2024

@ankit-thanekar007 not yet but I will let you know when we do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants