Added native support to inMobi bidder #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SerhiiNahornyi
suggested changes
Aug 27, 2021
| @@ -134,6 +134,9 @@ private static BidType getBidType(String impId, List<Imp> imps) { | |||
| if (imp.getId().equals(impId) && imp.getVideo() != null) { | |||
| return BidType.video; | |||
| } | |||
| if (imp.getId().equals(impId) && imp.getXNative() != null) { | |||
There was a problem hiding this comment.
imp.getId().equals(impId) used in 134 and 137 line, pls concat this statements to one
SerhiiNahornyi
suggested changes
Aug 30, 2021
| @@ -131,8 +131,15 @@ private Imp updateImp(Imp imp) { | |||
|
|
|||
| private static BidType getBidType(String impId, List<Imp> imps) { | |||
| for (Imp imp : imps) { | |||
| if (imp.getId().equals(impId) && imp.getVideo() != null) { | |||
| return BidType.video; | |||
|
|
|||
There was a problem hiding this comment.
Pls remove redundant \n in 134 and 136
SerhiiNahornyi
approved these changes
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prebid/prebid-server#1928