Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synacormedia: Renames to "imds", mirrors prebid-server-go features, adds GPP macros #2371

Merged
merged 5 commits into from
Jul 11, 2023
Merged

Synacormedia: Renames to "imds", mirrors prebid-server-go features, adds GPP macros #2371

merged 5 commits into from
Jul 11, 2023

Conversation

ecammit
Copy link
Contributor

@ecammit ecammit commented May 19, 2023 •
edited
Loading

Synacormedia: Renames to "imds" and updates the endpoint configurations to match the latest. (see: prebid/prebid.github.io#4237)

  • The endpoint config now mirrors the golang prebid-server
  • Imds uses a single endpoint hostname instead of a dynamic hostname, for efficiency of open connections (see: PBS2.0: bidders with dynamic hosts prebid-server#2612)
  • Imds uses https to allow HTTP/2 negotiation
  • Marks synacormedia as a deprecated alias for later removal using the deprecated-names functionality.

Core: Fixes deprecated-names feature to correctly evaluate bidder names from request.imp[].ext.prebid.bidder.* instead of request.imp[].ext.*.

No other bidder seems to be using deprecated-names, so the bug has gone un-noticed since the original pull request (#169) was merged. Upon fixing this, I now receive the expected value in the response:

  "ext": {
    "errors": {
      "synacormedia": [
        {
          "code": 2,
          "message": "synacormedia has been deprecated and is no longer available. Use imds instead."
        }
      ]
    },

If you would like this bug fix split into a separate pull request, I can do that.

ecammit added 2 commits May 19, 2023 10:04
@ecammit
Synacormedia: Renames to "imds" to mirror golang prebid-server and ma…
741390c 
…rks as a deprecated alias for later removal.

Core: Fixes deprecated-names feature to correctly evaluate bidder names from request.imp[].ext.prebid.bidder.* instead of request.imp[].ext.*.
@ecammit
imds: shorten some lines longer than 120 characters to get builds to …
f787032 
…pass
@ecammit ecammit changed the title Synacormedia: Renames to "imds" Synacormedia: Renames to "imds", mirrors prebid-server-go features, adds GPP macros Jun 27, 2023
@ecammit ecammit mentioned this pull request Jun 27, 2023
Merged
8 tasks
And1sS
And1sS requested changes Jul 4, 2023
View reviewed changes
src/main/java/org/prebid/server/bidder/imds/ImdsBidder.java Outdated
Comment on lines 99 to 100
String accountId = URLEncoder.encode(firstExtImp.getSeatId(), StandardCharsets.UTF_8);
String sourceId = URLEncoder.encode(prebidVersion, StandardCharsets.UTF_8);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, use final keyword everywhere where variable is not reassigned. Also, please, check for similar occurences.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

@ecammit ecammit requested a review from And1sS July 5, 2023 14:14
@SerhiiNahornyi SerhiiNahornyi merged commit 96d8ba5 into prebid:master Jul 11, 2023
@cross-repo-issue-creation cross-repo-issue-creation bot mentioned this pull request Jul 11, 2023
Closed
@SerhiiNahornyi SerhiiNahornyi mentioned this pull request Jul 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@And1sS And1sS And1sS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ecammit @And1sS @SerhiiNahornyi