Add storedAuctionResponse on imp level. #3461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+310
to
+318
| final Map<String, String> storedResponse = new HashMap<>(); | ||
| storedResponse.put("storedAuctionResponse1", mapper.writeValueAsString(asList( | ||
| SeatBid.builder().seat("appnexus").bid(singletonList(Bid.builder().id("id1").build())).build(), | ||
| SeatBid.builder().seat("rubicon").bid(singletonList(Bid.builder().id("id3").build())).build()))); | ||
| storedResponse.put("storedAuctionResponse2", mapper.writeValueAsString(singletonList( | ||
| SeatBid.builder().seat("rubicon").bid(singletonList(Bid.builder().id("id2").build())).build()))); | ||
|
|
||
| given(applicationSettings.getStoredResponses(any(), any())).willReturn( | ||
| Future.succeededFuture(StoredResponseDataResult.of(storedResponse, emptyList()))); |
There was a problem hiding this comment.
it has redundant returning values, the test needs only storedAuctionResponse2, also I suggest checking that the first argument of the getStoredResponses contains only storedAuctionResponse2
Comment on lines
+125
to
+127
| .map(impIdToExtPrebid -> Tuple2.of( | ||
| impIdToExtPrebid.getKey(), | ||
| extractAuctionStoredResponseId(impIdToExtPrebid.getValue()))) |
There was a problem hiding this comment.
why do we use a custom Tuple2 when there is a Pair class from Apache libraries?
Compile-Ninja
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
What's the context for the changes? Are there any
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check