Sovrn: Accept Imp.ext Bidfloor either as a number or string #3484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoxaAntoxic
requested changes
Oct 11, 2024
Comment on lines
107
to
124
| private static BigDecimal resolveBidFloor(BigDecimal impBidFloor, JsonNode extBidFloor) { | ||
| final BigDecimal fromExt = parseBidFloor(extBidFloor); | ||
| return !BidderUtil.isValidPrice(impBidFloor) && BidderUtil.isValidPrice(fromExt) ? fromExt : impBidFloor; | ||
| } | ||
|
|
||
| private static BigDecimal parseBidFloor(JsonNode extBidFloor) { | ||
| if (extBidFloor != null) { | ||
| if (extBidFloor.isNumber()) { | ||
| return extBidFloor.decimalValue(); | ||
| } else if (extBidFloor.isTextual()) { | ||
| try { | ||
| return new BigDecimal(extBidFloor.textValue()); | ||
| } catch (NumberFormatException e) { | ||
| return BigDecimal.ZERO; | ||
| } | ||
| } | ||
| } | ||
| return BigDecimal.ZERO; |
There was a problem hiding this comment.
you can revert this entirely as well as reverting the type change in the ExtImpSovrn, since both a string and a number will be successfully deserialized to BigDecimal
the only change you need is changing the json scheme, everything else should work fine
in order to test whether it works you can play with the integration test SovrnTest by changing values in the request json to double-check it works as intended
There was a problem hiding this comment.
thank you for making it simpler.
| @@ -16,7 +15,7 @@ public class ExtImpSovrn { | |||
| @JsonProperty("tagId") | |||
| String legacyTagId; | |||
|
|
|||
| BigDecimal bidfloor; | |||
| JsonNode bidfloor; | |||
AntoxaAntoxic
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
purpose of this commit is to fix this issue : prebid/prebid-server#3514
🧠 Rationale behind the change
🧪 Test plan
🏎 Quality check