OpenX adapter: Pass rewarded video signal #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpanchyk
previously approved these changes
May 22, 2020
| @Builder | ||
| public class OpenxVideoExt { | ||
|
|
||
| @JsonProperty("rewarded") |
There was a problem hiding this comment.
Minor. We don't need annotation here, since the field name will not be changed after marshaling to JSON.
|
|
||
| if (resolveImpType(imp) == OpenxImpType.video | ||
| && prebidImpExt != null | ||
| && prebidImpExt.getIsRewardedInventory() != null |
There was a problem hiding this comment.
Hint: we can use Objects.equals(...) helper here, so will avoid one check.
|
Appreciate the feedback, incorporated your suggestions. |
laurb9
force-pushed
the
openx-rewarded-video
branch
from
4c57b13 to
3a56d77
Compare
|
@rpanchyk, is there anything else we need to do for this? |
No, nothing more, thank you. |
rpanchyk
approved these changes
Jun 25, 2020
|
Sorry, but planned to include in 1.38.0 release. Along with this PR, next ones will be merged: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.