privacy: Do not modify User.Ext or Regs.Ext if json.Marshal reports a…

…n error.
prebid · May 27, 2020 · 27e2e11 · 27e2e11
1 parent 255fc04
commit 27e2e11
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/privacy/ccpa/policy.go b/privacy/ccpa/policy.go
@@ -40,10 +40,11 @@ func (p Policy) Write(req *openrtb.BidRequest) error {
 		req.Regs = &openrtb.Regs{}
 	}
 
-	var err error
-
 	if req.Regs.Ext == nil {
-		req.Regs.Ext, err = json.Marshal(openrtb_ext.ExtRegs{USPrivacy: p.Value})
+		ext, err := json.Marshal(openrtb_ext.ExtRegs{USPrivacy: p.Value})
+		if err == nil {
+			req.Regs.Ext = ext
+		}
 		return err
 	}
 

diff --git a/privacy/gdpr/policy.go b/privacy/gdpr/policy.go
@@ -25,10 +25,11 @@ func (p Policy) Write(req *openrtb.BidRequest) error {
 		req.User = &openrtb.User{}
 	}
 
-	var err error
-
 	if req.User.Ext == nil {
-		req.User.Ext, err = json.Marshal(openrtb_ext.ExtUser{Consent: p.Consent})
+		ext, err := json.Marshal(openrtb_ext.ExtUser{Consent: p.Consent})
+		if err == nil {
+			req.User.Ext = ext
+		}
 		return err
 	}