Skip to content

Commit

Permalink
Smaato: Rename adapter type
Browse files Browse the repository at this point in the history
  • Loading branch information
el-chuck committed Jul 14, 2021
1 parent 33c3a7c commit 67abd0d
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 13 deletions.
18 changes: 9 additions & 9 deletions adapters/smaato/smaato.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ const (
smtAdTypeVideo adMarkupType = "Video"
)

// SmaatoAdapter describes a Smaato prebid server adapter.
type SmaatoAdapter struct {
// adapter describes a Smaato prebid server adapter.
type adapter struct {
clock timeutil.Time
endpoint string
}
Expand Down Expand Up @@ -66,15 +66,15 @@ type videoExt struct {

// Builder builds a new instance of the Smaato adapter for the given bidder with the given config.
func Builder(bidderName openrtb_ext.BidderName, config config.Adapter) (adapters.Bidder, error) {
bidder := &SmaatoAdapter{
bidder := &adapter{
clock: &timeutil.RealTime{},
endpoint: config.Endpoint,
}
return bidder, nil
}

// MakeRequests makes the HTTP requests which should be made to fetch bids.
func (adapter *SmaatoAdapter) MakeRequests(request *openrtb2.BidRequest, reqInfo *adapters.ExtraRequestInfo) ([]*adapters.RequestData, []error) {
func (adapter *adapter) MakeRequests(request *openrtb2.BidRequest, reqInfo *adapters.ExtraRequestInfo) ([]*adapters.RequestData, []error) {
if len(request.Imp) == 0 {
return nil, []error{&errortypes.BadInput{Message: "No impressions in bid request."}}
}
Expand All @@ -94,7 +94,7 @@ func (adapter *SmaatoAdapter) MakeRequests(request *openrtb2.BidRequest, reqInfo
}

// MakeBids unpacks the server's response into Bids.
func (adapter *SmaatoAdapter) MakeBids(internalRequest *openrtb2.BidRequest, externalRequest *adapters.RequestData, response *adapters.ResponseData) (*adapters.BidderResponse, []error) {
func (adapter *adapter) MakeBids(internalRequest *openrtb2.BidRequest, externalRequest *adapters.RequestData, response *adapters.ResponseData) (*adapters.BidderResponse, []error) {
if response.StatusCode == http.StatusNoContent {
return nil, nil
}
Expand Down Expand Up @@ -153,7 +153,7 @@ func (adapter *SmaatoAdapter) MakeBids(internalRequest *openrtb2.BidRequest, ext
return bidResponse, errors
}

func (adapter *SmaatoAdapter) makeIndividualRequests(request *openrtb2.BidRequest) ([]*adapters.RequestData, []error) {
func (adapter *adapter) makeIndividualRequests(request *openrtb2.BidRequest) ([]*adapters.RequestData, []error) {
imps := request.Imp

requests := make([]*adapters.RequestData, 0, len(imps))
Expand All @@ -178,7 +178,7 @@ func (adapter *SmaatoAdapter) makeIndividualRequests(request *openrtb2.BidReques
return requests, errors
}

func (adapter *SmaatoAdapter) makePodRequests(request *openrtb2.BidRequest) ([]*adapters.RequestData, []error) {
func (adapter *adapter) makePodRequests(request *openrtb2.BidRequest) ([]*adapters.RequestData, []error) {
pods, orderedKeys, errors := groupImpressionsByPod(request.Imp)
requests := make([]*adapters.RequestData, 0, len(pods))

Expand All @@ -202,7 +202,7 @@ func (adapter *SmaatoAdapter) makePodRequests(request *openrtb2.BidRequest) ([]*
return requests, errors
}

func (adapter *SmaatoAdapter) makeRequest(request *openrtb2.BidRequest) (*adapters.RequestData, error) {
func (adapter *adapter) makeRequest(request *openrtb2.BidRequest) (*adapters.RequestData, error) {
reqJSON, err := json.Marshal(request)
if err != nil {
return nil, err
Expand Down Expand Up @@ -236,7 +236,7 @@ func getAdMarkupType(response *adapters.ResponseData, adMarkup string) (adMarkup
}
}

func (adapter *SmaatoAdapter) getTTLFromHeaderOrDefault(response *adapters.ResponseData) int64 {
func (adapter *adapter) getTTLFromHeaderOrDefault(response *adapters.ResponseData) int64 {
ttl := int64(300)

if expiresAtMillis, err := strconv.ParseInt(response.Headers.Get("X-Smt-Expires"), 10, 64); err == nil {
Expand Down
8 changes: 4 additions & 4 deletions adapters/smaato/smaato_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,15 @@ func TestJsonSamples(t *testing.T) {
t.Fatalf("Builder returned unexpected error %v", buildErr)
}

smaatoAdapter, _ := bidder.(*SmaatoAdapter)
assert.NotNil(t, smaatoAdapter.clock)
smaatoAdapter.clock = &mockTime{time: time.Date(2021, 6, 25, 10, 00, 0, 0, time.UTC)}
adapter, _ := bidder.(*adapter)
assert.NotNil(t, adapter.clock)
adapter.clock = &mockTime{time: time.Date(2021, 6, 25, 10, 00, 0, 0, time.UTC)}

adapterstest.RunJSONBidderTest(t, "smaatotest", bidder)
}

func TestVideoWithCategoryAndDuration(t *testing.T) {
bidder := &SmaatoAdapter{}
bidder := &adapter{}

mockedReq := &openrtb2.BidRequest{
Imp: []openrtb2.Imp{{
Expand Down

0 comments on commit 67abd0d

Please sign in to comment.