Skip to content

Commit

Permalink
Cnvr Adapter: dont need a shallow copy of the request
Browse files Browse the repository at this point in the history
  • Loading branch information
johwier committed Apr 15, 2024
1 parent 922c620 commit c98be34
Showing 1 changed file with 8 additions and 9 deletions.
17 changes: 8 additions & 9 deletions adapters/conversant/conversant.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,9 @@ type ConversantAdapter struct {
}

func (c *ConversantAdapter) MakeRequests(request *openrtb2.BidRequest, reqInfo *adapters.ExtraRequestInfo) ([]*adapters.RequestData, []error) {
cnvrRequest := *request
//Backend needs USD or it will reject the request
if len(cnvrRequest.Cur) > 0 && cnvrRequest.Cur[0] != "USD" {
cnvrRequest.Cur = []string{"USD"}
if len(request.Cur) > 0 && request.Cur[0] != "USD" {
request.Cur = []string{"USD"}
}
for i := 0; i < len(request.Imp); i++ {
var bidderExt adapters.ExtImpBidder
Expand All @@ -48,22 +47,22 @@ func (c *ConversantAdapter) MakeRequests(request *openrtb2.BidRequest, reqInfo *
if i == 0 {
if request.Site != nil {
tmpSite := *request.Site
cnvrRequest.Site = &tmpSite
cnvrRequest.Site.ID = cnvrExt.SiteID
request.Site = &tmpSite
request.Site.ID = cnvrExt.SiteID
} else if request.App != nil {
tmpApp := *request.App
cnvrRequest.App = &tmpApp
cnvrRequest.App.ID = cnvrExt.SiteID
request.App = &tmpApp
request.App.ID = cnvrExt.SiteID
}
}
err := parseCnvrParams(&cnvrRequest.Imp[i], cnvrExt, reqInfo)
err := parseCnvrParams(&request.Imp[i], cnvrExt, reqInfo)
if err != nil {
return nil, err
}
}

//create the request body
data, err := json.Marshal(cnvrRequest)
data, err := json.Marshal(request)
if err != nil {
return nil, []error{&errortypes.BadInput{
Message: "Error in packaging request to JSON",
Expand Down

0 comments on commit c98be34

Please sign in to comment.