feat: change getImpressionExt code

prebid · Oct 18, 2024 · ef7a58c · ef7a58c
1 parent 4ca9543
commit ef7a58c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/adapters/tradplus/tradplus.go b/adapters/tradplus/tradplus.go
@@ -88,6 +88,12 @@ func getImpressionExt(imp *openrtb2.Imp) (*openrtb_ext.ExtImpTradPlus, error) {
 		}
 	}
 
+	if tradplusExt.AccountID == "" {
+		return nil, &errortypes.BadInput{
+			Message: "imp.ext.accountId required",
+		}
+	}
+
 	return &tradplusExt, nil
 }
 

diff --git a/adapters/tradplus/tradplustest/supplemental/bad_imp_ext.json b/adapters/tradplus/tradplustest/supplemental/bad_imp_ext.json
@@ -14,7 +14,7 @@
 
   "expectedMakeRequestsErrors": [
     {
-      "value": "json: cannot unmarshal string into Go value of type adapters.ExtImpBidder",
+      "value": "Error parsing tradplusExt - json: cannot unmarshal string into Go value of type adapters.ExtImpBidder",
       "comparison": "literal"
     }
   ]

diff --git a/adapters/tradplus/tradplustest/supplemental/bad_imp_ext_bidder.json b/adapters/tradplus/tradplustest/supplemental/bad_imp_ext_bidder.json
@@ -20,7 +20,7 @@
   },
   "expectedMakeRequestsErrors": [
     {
-      "value": "json: cannot unmarshal string into Go value of type openrtb_ext.ExtImpTradPlus",
+      "value": "Error parsing bidderExt - json: cannot unmarshal string into Go value of type openrtb_ext.ExtImpTradPlus",
       "comparison": "literal"
     }
   ]