Client connecting to S2S adapter failing #575
Comments
|
yeah, Prebid.js 0.x versions aren't really supported at all anymore. I'm pretty sure My recommendation would be:
Then upgrade to the latest 1.x version. |
|
@dbemiller Thanks for your response.
I updated Publisher on that and we can wait till the your PR is done to
start an end to end testing.
One concern I received from publisher side when I asked them to take latest
Prebid.js version build is as follows:
*"**I can pull the latest, but in reality it’s not that easy, because most
pubs doesn’t want to update to prebid 1.xx yet, in part because some major
bidders are still not fully ready yet. *
*So I recommend to make your bidder backward compatible if this truly
should be the issue.**"*
So looks like they are unsure about whether they can make a move to 1.x.x
version immediately. Please advise.
…On Wed, Jun 20, 2018 at 5:19 AM, dbemiller ***@***.***> wrote:
yeah, Prebid.js 0.x versions aren't really supported at all anymore. I'm
pretty sure /openrtb2/auction was never implemented there. They'll have
to upgrade to Prebid.js 1.x to call you.
My recommendation would be:
1. Wait for prebid/Prebid.js#2743
<prebid/Prebid.js#2743> to get merged, and the
next 1.x release (they happen every 2 weeks). It's a super important bugfix.
2. Set s2sconfig.timeout to be the same as their client-side auction
timeout. If they don't define a client-side auction timeout, they should
use 3000 milliseconds. That works around another PBJS bug described by this
comment
<prebid/Prebid.js#2648 (comment)>
.
Then upgrade to the latest 1.x version.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#575 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AlkKirr8DforWBzcsLdkonnDL_SfhHE-ks5t-j3BgaJpZM4UuW7B>
.
|
|
One more thing, I hope the Prebid.js 1.x.x. version will support both client side adapter calls along with server side adapter calls as well. Please confirm. |
|
Also I just noticed that this prebid/Prebid.js#2743 got merged. Should we wait for anything else to take latest Prebid.js for testing? |
The publisher seems... a little confused. I can understand why. They're right that some publishers have reasons to avoid using Prebid.js 1.x. They may be overestimating how many. That was a major problem ~2 months ago, but mainly because a few really major bidders weren't in it yet. They were added recently, though... so I'm not sure how widespread of a concern it is anymore. If they can't upgrade to 1.x, it would take some significant work for them to be able to call you. This has nothing to do with your adapter--just the features built into the core project. Compare the Prebid.js code which calls Prebid Server in 1.x and 0.x. It was almost completely rewritten, and the 0.x version has no ability to use OpenRTB in Prebid Server at all. Another issue is that prebid/Prebid.js#2704, which supports your adapter, was made in 1.x only. Both these features would have to be ported back to 0.x to make it work... which is a significant time investment.
Nope, you're all set. Make sure they use the latest release, and set |
|
As a very rough estimate, we see ~2/3 of our prebid impressions being served through 1.x, with ~1/3 being served through 0.x. |
|
Thanks @dbemiller for your responses. Please confirm. |
|
Yes, that is correct. |
|
One of our publishers updated their test page with the latest prebid version. However, it doesn’t seem to work correctly. They don’t see the s2s call being initiated Can you please check the way they are calling brightroll adapter is correct or not? Please advise |
|
You'll probably get better answers about that one in the Prebid.js repo. If there's no server call, then the issue can't be a Prebid Server one. The community over there is more active, and many people there are more familiar with debugging publisher pages than I am. |
|
For what it's worth, I set a breakpoint on the
and don't see any
So.... that strikes me as a bit suspicious. |
|
I see, thanks for looking into it. I also enabled debug mode. It looks like “bidsBackHandler” is not defined.
|
|
Please discard my above comment |
|
ok... should we close this, then? Or are there any other outstanding issues? |
|
We havn't successfully finished our client testing yet. Lets keep it open for couple of days, in case if we have to troubleshoot or need any help from your side for any issues. Thanks! |
|
Seems like enough time has passed to close this now? |
|
Sure, We are good now. please close it. Thanks
…On Thu, Aug 23, 2018 at 1:46 PM, hhhjort ***@***.***> wrote:
Seems like enough time has passed to close this now?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#575 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AlkKiqKrvr9k95saBvav46Pi1OlpHNwmks5uTxTDgaJpZM4UuW7B>
.
|
Problem:
One of our publishers is trying to test S2S adapter(brightroll) using Prebid.js version 0.34.1
By following the documentation here https://github.com/prebid/prebid.github.io/pull/834/files, they are using endpoint/requestURL https://prebid.adnxs.com/pbs/v1/openrtb2/auction, And also
passing all custom params and bidder details in Request payload, something like this :
{"account_id":"XXX","tid":"XXXX","max_bids":1,"timeout_millis":1000,"url":"xxx","prebid_version":"0.23.1","ad_units":[{"code":"div-gpt-ad-919604695-1","sizes":[{"w":728,"h":90},{"w":970,"h":250},{"w":970,"h":90},{"w":468,"h":60},{"w":1800,"h":600}],"bids":[{"bidder":"brightroll","params":{"publisherName":"adthrive","slot":229},"bid_id":"15adcac0bc90f8"}],"transactionId":"43c7e84a-25f6-4c9a-85d1-fc85d7dc2457"},.......]}
But receiving "400 Bad Request" and error message as "Invalid request: request missing required field: "id" "
Question:
Please advise
The text was updated successfully, but these errors were encountered: