-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mapping of user.ext.eids[] for LiveIntent in Rubicon bidder #1089
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
0e104a0
Add mapping of user.ext.eids[] for LiveIntent in Rubicon bidder
7143f2f
Add mapping of user.ext.eids[] for LiveIntent in Rubicon bidder - fix PR
0ec2adc
Add mapping of user.ext.eids[] for LiveIntent in Rubicon bidder - fix PR
a469a33
Merge branch 'master' into copy-liveintentid-to-tpid
1406caf
Merge branch 'master' into copy-liveintentid-to-tpid
9da401f
Add mapping of user.ext.eids[] for LiveIntent in Rubicon bidder - fix PR
ed5a47f
Add mapping of user.ext.eids[] for LiveIntent in Rubicon bidder - fix…
f820b5d
Merge branch 'master' into copy-liveintentid-to-tpid
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider moving this
if
block and it'selse
block into their own functions for better readability and easier unit testing. For example, in case where source isliveintent.com
,tpId.UID
is set touids[0].ID
but that's not covered in the unit test and with a unit test trying to test the entire OpenRTB request, it is hard to incorporate all the different test cases. Breaking it into smaller functions will help with better test coverage.