Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beachfront: GDPR id (issue 1301) and documentation updates #1321

Merged
merged 9 commits into from
Jun 2, 2020
Merged

Beachfront: GDPR id (issue 1301) and documentation updates #1321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ba3b9b8
Defined cookie sync URL in config, cleared deprecated comment in user…
Nov 1, 2018
8efff88
Merge branch 'master' of https://github.com/prebid/prebid-server
Nov 5, 2018
dc08701
Merge branch 'master' of https://github.com/prebid/prebid-server
Nov 6, 2018
30c9af2
merged from upstream
May 15, 2020
fde9619
Update beachfront.md
muncha May 15, 2020
a3c8d35
editing documentation
May 15, 2020
c16f90f
Merge branch 'master' of https://github.com/prebid/prebid-server
May 29, 2020
11e64ba
Merge branch 'master' into documentation
May 29, 2020
b3262fb
updated gdpr id - issue 1301
Jun 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion adapters/beachfront/usersync.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ import (
"github.com/prebid/prebid-server/usersync"
)

var VENDOR_ID uint16 = 335

func NewBeachfrontSyncer(temp *template.Template) usersync.Usersyncer {
return adapters.NewSyncer("beachfront", 0, temp, adapters.SyncTypeIframe)
return adapters.NewSyncer(
"beachfront",
VENDOR_ID,
temp,
adapters.SyncTypeIframe)
}
2 changes: 1 addition & 1 deletion adapters/beachfront/usersync_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,6 @@ func TestBeachfrontSyncer(t *testing.T) {
assert.NoError(t, err)
assert.Equal(t, "https://sync.bfmio.com/sync_s2s?gdpr=A&us_privacy=C&url=https%3A%2F%2Flocalhost%3A8888%2Fsetuid%3Fbidder%3Dbeachfront%26gdpr%3DA%26gdpr_consent%3DB%26uid%3D%5Bio_cid%5D", syncInfo.URL)
assert.Equal(t, "iframe", syncInfo.Type)
assert.EqualValues(t, 0, syncer.GDPRVendorID())
assert.EqualValues(t, uint16(335), syncer.GDPRVendorID())
assert.Equal(t, false, syncInfo.SupportCORS)
}
10 changes: 8 additions & 2 deletions docs/bidders/beachfront.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
# Beachfront bidder

To use the beachfront bidder you will need an appId from an exchange
account on [https://platform.beachfront.io](platform.beachfront.io).
To use the beachfront bidder you will need an appId (Exchange Id) from an exchange
account on [platform.beachfront.io](https://platform.beachfront.io).

For further information, please contact adops@beachfront.com.

As seen in the JSON response from \{your PBS server\}\/bidder\/params [(example)](https://prebid.adnxs.com/pbs/v1/bidders/params), the beachfront bidder can take either an "appId" parameter, or an "appIds" parameter. If the request is for one media type, the appId parameter should be used with the value of the Exchange Id on the Beachfront platform.

The appIds parameter is for requesting a mix of banner and video. It has two parameters, "banner", and "video" for the appIds of two appropriately configured exchanges on the platform. The appIds parameter can be sent with just one of its two parameters and it will behave like the appId parameter.

If the request includes an appId configured for a video response, the videoResponseType parameter can be defined as "nurl", "adm" or "both". These will apply to all video returned. If it is not defined, the response type will be a nurl. The definitions for "nurl" vs. "adm" are here: (https://github.com/mxmCherry/openrtb/blob/master/openrtb2/bid.go).