-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add client/AccountID support into Adoppler adapter. #1535
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
671f5a8
Add client/AccountID support into Adoppler adapter.
vchimishuk ea7c95a
Addressed code review comments.
vchimishuk bf045ec
Fix multiimp.json testcase.
vchimishuk ea3afeb
Fix broken multiimp.json test.
vchimishuk 6591c3c
Move rest of the bid URI into config.
vchimishuk 479452a
Make exemplary tests return 200.
vchimishuk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 52 additions & 0 deletions
52
adapters/adoppler/adopplertest/exemplary/custom-client.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
{ | ||
"mockBidRequest":{ | ||
"id":"req1", | ||
"imp":[ | ||
{ | ||
"id":"imp1", | ||
"banner":{ | ||
"w":100, | ||
"h":200 | ||
}, | ||
"ext":{ | ||
"bidder":{ | ||
"adunit":"unit1", | ||
"client":"client1" | ||
} | ||
} | ||
} | ||
] | ||
}, | ||
"httpCalls":[ | ||
{ | ||
"expectedRequest":{ | ||
"uri":"http://client1.trustedmarketplace.com/processHeaderBid/unit1", | ||
"body":{ | ||
"id":"req1-unit1", | ||
"imp":[ | ||
{ | ||
"id":"imp1", | ||
"banner":{ | ||
"w":100, | ||
"h":200 | ||
}, | ||
"ext":{ | ||
"bidder":{ | ||
"adunit":"unit1", | ||
"client":"client1" | ||
} | ||
} | ||
} | ||
] | ||
} | ||
}, | ||
"mockResponse":{ | ||
"status":204, | ||
"body":"" | ||
} | ||
} | ||
], | ||
"expectedBidResponses":[ | ||
|
||
] | ||
} |
50 changes: 50 additions & 0 deletions
50
adapters/adoppler/adopplertest/exemplary/default-client.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
{ | ||
"mockBidRequest":{ | ||
"id":"req1", | ||
"imp":[ | ||
{ | ||
"id":"imp1", | ||
"banner":{ | ||
"w":100, | ||
"h":200 | ||
}, | ||
"ext":{ | ||
"bidder":{ | ||
"adunit":"unit1" | ||
} | ||
} | ||
} | ||
] | ||
}, | ||
"httpCalls":[ | ||
{ | ||
"expectedRequest":{ | ||
"uri":"http://app.trustedmarketplace.com/processHeaderBid/unit1", | ||
"body":{ | ||
"id":"req1-unit1", | ||
"imp":[ | ||
{ | ||
"id":"imp1", | ||
"banner":{ | ||
"w":100, | ||
"h":200 | ||
}, | ||
"ext":{ | ||
"bidder":{ | ||
"adunit":"unit1" | ||
} | ||
} | ||
} | ||
] | ||
} | ||
}, | ||
"mockResponse":{ | ||
"status":204, | ||
"body":"" | ||
} | ||
} | ||
], | ||
"expectedBidResponses":[ | ||
|
||
] | ||
} |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest adding valid expected bid responses for this and the next test rather than an empty response because that exercises the
MakeBids
code of your adapter.